MrkvNow into model state shocks['Mrkv'] in AggShockMarkov and KrusellSmith models #935
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #933.
In the AggShockMarkov and KrusellSmith agents and associated economies, the
MrkvNow
property was being set as an object attribute, despite being a model variable. It's an aggregate property in both cases.This PR replaces these with a shock
Mrkv
. This is small progress towards #920, which otherwise can be done with simple search-and-replace operations.Mrkv
is a shock and not a state in this implementation because the way Market interactions with the Agent currently works, if the Market sets and agent state in itssow
step, it will be rolled over into thestate_prev
namespace during the simulation in thecultivate
step. Because here theMrkv
state really is exogenous to the agent,shocks
seems more appropriate, though I hope we can scaffold this a bit better in, say, v1.1