Remove "Now" from model variables #936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbenthall
commented
Feb 4, 2021
| @@ -1863,7 +1875,7 @@ def __init__(self, agents=None, tolerance=0.0001, act_T=1200, **kwds): | |||
| Market.__init__( | |||
| self, | |||
| agents=agents, | |||
| reap_vars=["aLvlNow", "pLvlNow"], | |||
| reap_vars=['aLvl', 'pLvl'], | |||
| track_vars=["MaggNow", "AaggNow"], | |||
There was a problem hiding this comment.
These variables should be renamed
|
Fix |
3 tasks
|
Punting on MaggNow and AaggNow to #942 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes "Now" from all the model variables in ConsumptionSaving
This builds on #935 , which should be merged first, as that regularizes the
MrkvNowattribute into aMrkvmodel variable and requires some code changes.This is main search and replace of key terms.
I've only touched the model variable names represented as strings, not the python variable names, which I see as covered by #907, a separate issue. With one exception:
millRuletakes its argument names from a dictionary of var names, and so I had to adjust these functions.One thing I haven't yet done in this PR is test to see if the
examples/still work after this PR. I forget if our automated tests catch errors in those. I expect to do a pass on the examples for issue #488 but may not get to it for a while.We should make testing the
examples/a part of the release procedure if we don't have them as part of automated tests.