feat: Use Http Request timeout handler #267
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
Codecov Report
@@ Coverage Diff @@
## main #267 +/- ##
=======================================
Coverage 58.90% 58.90%
=======================================
Files 12 12
Lines 786 786
=======================================
Hits 463 463
Misses 309 309
Partials 14 14 Continue to review full report at Codecov.
|
weichou1229
changed the title
To handler the Request timeout properly, we can use TimeoutHandler to provide more meaningful error message and status code, and we also need to remove the timeout settings from the Http server to make the timeout handler works. Close edgexfoundry#268 Signed-off-by: weichou <weichou1229@gmail.com>
weichou1229
force-pushed
the
rm-req-timeout-setting
branch
from
9d22598 to
a06c5a1
Compare
|
Issue created #268 |
| return false | ||
| } | ||
|
|
||
| b.router.Use(func(next http.Handler) http.Handler { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close: #268
PR Checklist
Please check if your PR fulfills the following requirements:
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/go-mod-bootstrap/blob/master/.github/Contributing.md.
What is the current behavior?
Http server close the conn when request timeout and didn't return any useful message.
Issue Number: #268
What is the new behavior?
Since we can use timeout handler to provide more meaningful error message, we need to remove the timeout settings from the Http server to make the timeout handler works.
Does this PR introduce a breaking change?
New Imports
Specific Instructions
Are there any specific instructions or things that should be known prior to reviewing?
Other information