-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flow and step for opening designs in Magic #463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Metric comparisons are in beta. Please report bugs under the issues tab.
Full tables ► https://gist.github.com/openlane-bot/4d54e593d0fd68b52199a45d09d7187e |
## Steps * `Magic.*` * Fixed `magicrc` being `abspath`'d before command invocation (breaks reproducibles) * Made `_MAGIC_SCRIPT` set in `prepare_env` ## Misc * `openlane.steps.Step.create_reproducible` * `PDK_ROOT` now included if the PDK is included but not flattened so Magic steps can work * `openlane.steps.TclStep` * **Internal**: Internal environment variables prefixed with `_` are no longer rerouted to `_env.tcl`, instead being passed raw (to help with reproducibles)
kareefardi
reviewed
May 23, 2024
kareefardi
reviewed
May 23, 2024
kareefardi
reviewed
May 23, 2024
kareefardi
reviewed
May 23, 2024
kareefardi
approved these changes
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps
Magic.OpenGUI
, which opens either DEF files or GDS files in magicMagic.*
magicrc
beingabspath
'd before command invocation (breaks reproducibles)_MAGIC_SCRIPT
is now set inprepare_env
instead ofrun_subprocess
(so it can be intercepted for reproducibles)KLayout.OpenGUI
KLAYOUT_PRIORITIZE_GDS
toKLAYOUT_GUI_USE_GDS
to be consistent with the Magic stepsFlows
OpenInMagic
, which runsMagic.OpenGUI
Tool Updates
nix-eda
for some of its derivations8.3.483
/291ba96
Misc Bugfixes/Enhancements
openlane.steps.Step.create_reproducible
PDK_ROOT
now included if the PDK is included but not flattened so Magic steps can workopenlane.steps.TclStep
_
are no longer rerouted to_env.tcl
, instead being passed raw (to help with creating reproducibles)