Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flow and step for opening designs in Magic #463

Merged
merged 9 commits into from
May 27, 2024
Merged

Flow and step for opening designs in Magic #463

merged 9 commits into from
May 27, 2024

Conversation

donn
Copy link
Member

@donn donn commented May 2, 2024

Steps

  • New step, Magic.OpenGUI, which opens either DEF files or GDS files in magic
  • Magic.*
    • Fixed magicrc being abspath'd before command invocation (breaks reproducibles)
    • _MAGIC_SCRIPT is now set in prepare_env instead of run_subprocess (so it can be intercepted for reproducibles)
  • KLayout.OpenGUI
    • Renamed KLAYOUT_PRIORITIZE_GDS to KLAYOUT_GUI_USE_GDS to be consistent with the Magic steps

Flows

  • New mono-step flow, OpenInMagic, which runs Magic.OpenGUI

Tool Updates

  • OpenLane 2 now uses nix-eda for some of its derivations
  • Magic now uses tk with X11 on macOS, to prevent crashes when attempting to use the GUI
  • Updated Magic to 8.3.483/291ba96

Misc Bugfixes/Enhancements

  • openlane.steps.Step.create_reproducible
    • PDK_ROOT now included if the PDK is included but not flattened so Magic steps can work
  • openlane.steps.TclStep
    • Internal: Internal environment variables prefixed with _ are no longer rerouted to _env.tcl, instead being passed raw (to help with creating reproducibles)

* New step, `Magic.OpenGUI`, which opens either DEF files or GDS files in magic

## Flows

* New mono-step flow, `OpenInMagic`, which runs `Magic.OpenGUI`

## Tool Updates
* Magic now uses tk with X11 on macOS, to prevent crashes when attempting to use the GUI
@donn donn marked this pull request as draft May 2, 2024 17:26
@openlane-bot
Copy link
Collaborator

openlane-bot commented May 2, 2024

Metric comparisons are in beta. Please report bugs under the issues tab.

To create this report yourself, grab the metrics artifact from the CI run, extract them, and invoke python3 -m openlane.common.metrics compare-main <path to directory>.

  • Changes to critical metrics were detected in the following designs:
    • sky130A/sky130_fd_sc_hd/aes_upw_new
    • sky130A/sky130_fd_sc_hd/aes_upw_old

Full tables ► https://gist.github.com/openlane-bot/4d54e593d0fd68b52199a45d09d7187e

donn added 6 commits May 7, 2024 14:44
## Steps
* `Magic.*`
  * Fixed `magicrc` being `abspath`'d before command invocation (breaks reproducibles)
  * Made `_MAGIC_SCRIPT` set in `prepare_env`

## Misc
* `openlane.steps.Step.create_reproducible`
  * `PDK_ROOT` now included if the PDK is included but not flattened so Magic steps can work
* `openlane.steps.TclStep`
   * **Internal**: Internal environment variables prefixed with `_` are no longer rerouted to `_env.tcl`, instead being passed raw (to help with reproducibles)
@donn donn marked this pull request as ready for review May 16, 2024 13:11
@donn donn requested a review from kareefardi May 16, 2024 13:11
openlane/steps/magic.py Outdated Show resolved Hide resolved
@donn donn requested a review from kareefardi May 27, 2024 08:12
@donn donn enabled auto-merge (squash) May 27, 2024 08:48
@donn donn merged commit 93e973f into dev May 27, 2024
105 checks passed
@donn donn deleted the lvs-guide branch May 30, 2024 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants