Skip to content
This repository was archived by the owner on Feb 20, 2019. It is now read-only.

Conversation

mitchellporter
Copy link
Contributor

closes #100

@codecov-io
Copy link

codecov-io commented Jul 2, 2017

Codecov Report

Merging #102 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #102   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          35     36    +1     
  Lines         103    105    +2     
=====================================
+ Hits          103    105    +2
Impacted Files Coverage Δ
src/is-function.js 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0251f0f...8e0448c. Read the comment docs.

Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome! Just one thing, could you do me a favor and remove the package-lock.json and add an entry for it in the .gitignore? I want to avoid people having to deal with merge conflicts in that file. Let me know if you need my help. Thank you so much!

removes package-lock.json and adds to .gitignore
@mitchellporter
Copy link
Contributor Author

mitchellporter commented Jul 2, 2017

Sure thing! I've removed package-lock.json and added it to the .gitignore as well.

Would you like me to squash the commits?

Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! Thanks so much! Don't worry about the commits, I can squash then and even with a new commit message via the GitHub UI (one of my favorite new features!)

@kentcdodds kentcdodds merged commit 0f7621e into eggheadio-github:master Jul 3, 2017
@mitchellporter mitchellporter deleted the pr/isFunction branch July 3, 2017 17:42
@mitchellporter
Copy link
Contributor Author

Awesome thanks again for putting this all together cheers!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a isFunction function
3 participants