Skip to content
This repository was archived by the owner on Feb 20, 2019. It is now read-only.

WIP: Add isPrime function #147

Merged
merged 2 commits into from
Jan 18, 2018
Merged

WIP: Add isPrime function #147

merged 2 commits into from
Jan 18, 2018

Conversation

alexandru-tomescu
Copy link
Contributor

Test PR for isPrime function viewed in Issues :)

Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A good start!

If you check out the travis build for this pull request, you'll notice there are some linting errors. You can run this script yourself with npm run lint.

If you could please fix those up that would be great :) Thanks!

@codecov-io
Copy link

codecov-io commented Jan 18, 2018

Codecov Report

Merging #147 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #147   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          53     54    +1     
  Lines         181    185    +4     
=====================================
+ Hits          181    185    +4
Impacted Files Coverage Δ
src/is-prime.js 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79b9e20...6459c29. Read the comment docs.

@alexandru-tomescu
Copy link
Contributor Author

Thanks for reviewing @kentcdodds . Now everything should be good. After you approve this PR and merge with master, how can i setup copy repo / master to automatically update itself from original repo / master ?

Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@kentcdodds kentcdodds merged commit 36a309f into eggheadio-github:master Jan 18, 2018
@kentcdodds
Copy link
Member

In answer to your question, I show you how to do that in this video: https://egghead.io/lessons/javascript-how-to-fork-and-clone-a-github-repository

Thanks again!

@alexandru-tomescu
Copy link
Contributor Author

Thank you @kentcdodds .

@alexandru-tomescu alexandru-tomescu deleted the lesson/is-prime branch January 18, 2018 13:31
@alexandru-tomescu alexandru-tomescu restored the lesson/is-prime branch January 18, 2018 13:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants