Skip to content
This repository was archived by the owner on Feb 20, 2019. It is now read-only.

feat(flatten): Implement variable arity for flatten function, add test #18

Merged
merged 1 commit into from
Feb 29, 2016
Merged

feat(flatten): Implement variable arity for flatten function, add test #18

merged 1 commit into from
Feb 29, 2016

Conversation

davidrayoussef
Copy link
Contributor

First PR. Added implementation for flatten function to accept multiple arrays, and added a test with multiple parameters.

@codecov-io
Copy link

Current coverage is 100.00%

Merging #18 into master will not affect coverage as of e467e3a

@@            master     #18   diff @@
======================================
  Files            5       5       
  Stmts           18      18       
  Branches         0       0       
  Methods          0       0       
======================================
  Hit             18      18       
  Partial          0       0       
  Missed           0       0       

Review entire Coverage Diff as of e467e3a

Powered by Codecov. Updated on successful CI builds.

@kentcdodds
Copy link
Member

Fantastic. This is great. Thank you for your contribution! Could you update the commit message to more closely follow the standard? The subject is too long and it should state that it's closing #17
Thanks!

@davidrayoussef
Copy link
Contributor Author

No, thank you Kent for helping me get my first green. But can you help me update the commit message? Should I do an npm run commit again? Because I'm getting an error since there are no changes. Or should I do a force push, or can I edit it right in Github?

@kentcdodds
Copy link
Member

In this scenario, the easiest would be to run git reset HEAD^ then do git diff to make sure the changes are what you expect, then run git add -A and run npm run commit or you could create your message by hand with git commit

Let me know if you need more direction!

@davidrayoussef
Copy link
Contributor Author

Okay cool. I think I got it right this time, but had to do a force push. Let me know if there's an issue.

@kentcdodds
Copy link
Member

Perfect! Thank you! And congrats on your first pull request!

kentcdodds pushed a commit that referenced this pull request Feb 29, 2016
feat(flatten): Implement variable arity for flatten function, add test
@kentcdodds kentcdodds merged commit 7268af2 into eggheadio-github:master Feb 29, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants