This repository was archived by the owner on Feb 20, 2019. It is now read-only.
enhacement(dec2hex): js + test #202
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@kentcdodds
The function and test were stright forward, however, I am gettting a strange error, confirmed by
eslint
:[eslint] dec2hex not found in '../src'
So when I run the test, it fails because it is not finding the module. I tried adding another
.js
module, and odd enough I was getting the same issue.I also tried default import like
import dec2hex from '../src'
but then I get[eslint] No default export found in module.
which makes sense if the module is not foundI ran
npm run lint
did not get any linting errors, and after ran anpm build
too, but I was not able to solve it.Can you please provide a guide so I can make the test run and be able to make the PR
Many thanks!!!!