Skip to content
This repository was archived by the owner on Feb 20, 2019. It is now read-only.

enhacement(dec2hex): js + test #202

Merged
merged 1 commit into from
Oct 25, 2018
Merged

enhacement(dec2hex): js + test #202

merged 1 commit into from
Oct 25, 2018

Conversation

EstebanMarin
Copy link
Contributor

@kentcdodds
The function and test were stright forward, however, I am gettting a strange error, confirmed by eslint: [eslint] dec2hex not found in '../src'

So when I run the test, it fails because it is not finding the module. I tried adding another .js module, and odd enough I was getting the same issue.

I also tried default import like import dec2hex from '../src' but then I get
[eslint] No default export found in module. which makes sense if the module is not found

I ran npm run lint did not get any linting errors, and after ran a npm build too, but I was not able to solve it.

Can you please provide a guide so I can make the test run and be able to make the PR

Many thanks!!!!

Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome! Could you make sure to make changes to src/index.js as well please?

@codecov-io
Copy link

Codecov Report

Merging #202 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #202   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          75     76    +1     
  Lines         327    329    +2     
=====================================
+ Hits          327    329    +2
Impacted Files Coverage Δ
src/dec2hex.js 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d39b0aa...1a2b928. Read the comment docs.

@EstebanMarin
Copy link
Contributor Author

@kentcdodds Thanks! after you said add it to src/index.js I slapped my self in the face 🤦🏻‍♂️

It is updated now. Many thanks!

Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super! 👏

@kentcdodds kentcdodds merged commit f9b0652 into eggheadio-github:master Oct 25, 2018
@EstebanMarin EstebanMarin mentioned this pull request Oct 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants