Skip to content
This repository was archived by the owner on Feb 20, 2019. It is now read-only.

feat(reduceCount): added reduceCount function #211

Merged
merged 2 commits into from
Dec 13, 2018
Merged

feat(reduceCount): added reduceCount function #211

merged 2 commits into from
Dec 13, 2018

Conversation

thall1961
Copy link
Contributor

I added reduceCount function to count occurrences of param in the array(s). This function uses recursion, if necessary, to find param and count it.

@codecov-io
Copy link

codecov-io commented Dec 10, 2018

Codecov Report

Merging #211 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #211   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          79     80    +1     
  Lines         333    341    +8     
=====================================
+ Hits          333    341    +8
Impacted Files Coverage Δ
src/reduceCount.js 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6a9c5e...b3431bd. Read the comment docs.

Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Things look good other than the .history folder :)

@@ -0,0 +1,161 @@
import reverseArrayInPlace from './reverseArrayInPlace'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should add .history/ to your .gitignore_global file on your machine.

Please do that, then run git rm -rf .history and update this branch with these files removed :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, pushed up without .history. Took a while to realize I was missing the : in the commit 🤦‍♂️

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about the commit thing. FWIW, I don't validate commit messages anymore. But I didn't want to change this repo from the course 😅

Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super!

@kentcdodds kentcdodds merged commit 486268f into eggheadio-github:master Dec 13, 2018
@kentcdodds
Copy link
Member

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants