This repository was archived by the owner on Feb 20, 2019. It is now read-only.
WIP: Add an "add" function #59
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 100% (diff: 100%)@@ master #59 diff @@
===================================
Files 15 16 +1
Lines 51 52 +1
Methods 0 0
Messages 0 0
Branches 0 0
===================================
+ Hits 51 52 +1
Misses 0 0
Partials 0 0
|
kentcdodds
suggested changes
Dec 19, 2016
| @@ -30,4 +31,5 @@ export { | |||
| isNullOrWhitespace, | |||
| startsWith, | |||
| removeDuplicates, | |||
| additon, | |||
There was a problem hiding this comment.
I would prefer that this were called add instead of addition. Care to make the update?
There was a problem hiding this comment.
Great. Sure, i would do that. Thanks a lot for quick response.
|
I have updated the PR . |
kentcdodds
approved these changes
Dec 19, 2016
|
Terrific! Thanks! |
|
Thanks for your help @kentcdodds :) Can you share the url for knowing what open source projects to contribute ? |
|
Yeah, check this out :-) |
|
Thanks a lot @kentcdodds . I will be helping the people who comes here to learn what i have learned. Thanks again for all your efforts. I really appreciate that. |
|
Awesome! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi , This is my first open source pull request . Seem like everything went good. While doing commit i have got stuck with code coverage.
failed with "(0 , _src.add) is not a function"
Hope to contribute more.