fix: camelcase option name before setting default value (#62)

* fix: camelcase option name

* add test

* camelcase option alias names too

Author: egoist

examples/negated-option.js

@@ -0,0 +1,8 @@
+require('ts-node/register')
+const cli = require('../src/index')()
+
+cli.option('--no-clear-screen', 'Do not clear screen')
+
+const parsed = cli.parse()
+
+console.log(JSON.stringify(parsed, null, 2))

src/CAC.ts

@@ -7,13 +7,7 @@ import Command, {
   CommandExample
 } from './Command'
 import { OptionConfig } from './Option'
-import {
-  getMriOptions,
-  camelcase,
-  setDotProp,
-  setByType,
-  getFileName
-} from './utils'
+import { getMriOptions, setDotProp, setByType, getFileName } from './utils'
 import { processArgs } from './node'
 
 interface ParsedArgv {
@@ -295,11 +289,9 @@ class CAC extends EventEmitter {
       }
     }
 
-    // Camelcase option names and set dot nested option values
+    // Set dot nested option values
     for (const key of Object.keys(parsed)) {
-      const keys = key.split('.').map((v, i) => {
-        return i === 0 ? camelcase(v) : v
-      })
+      const keys = key.split('.')
       setDotProp(options, keys, parsed[key])
       setByType(options, transforms)
     }

src/Option.ts

@@ -1,4 +1,4 @@
-import { removeBrackets } from './utils'
+import { removeBrackets, camelcase } from './utils'
 
 interface OptionConfig {
   default?: any
@@ -35,11 +35,21 @@ export default class Option {
           this.negated = true
           name = name.replace(/^no-/, '')
         }
+
+        // Camelcase the option name
+        // Don't camelcase anything after the dot `.`
+        name = name
+          .split('.')
+          .map((v, i) => {
+            return i === 0 ? camelcase(v) : v
+          })
+          .join('.')
+
         return name
       })
       .sort((a, b) => (a.length > b.length ? 1 : -1)) // Sort names
 
-    // Use the longese name (last one) as actual option name
+    // Use the longest name (last one) as actual option name
     this.name = this.names[this.names.length - 1]
 
     if (this.negated) {

src/__test__/index.test.ts

@@ -80,7 +80,18 @@ test('double dashes', () => {
   expect(options['--']).toEqual(['npm', 'test'])
 })
 
-test('negated optional validation', () => {
+test('default value for negated option', () => {
+  const cli = cac()
+
+  cli.option('--no-clear-screen', 'no clear screen')
+  cli.option('--no-a-b, --no-c-d', 'desc')
+
+  const { options } = cli.parse(`node bin`.split(' '))
+
+  expect(options).toEqual({ '--': [], clearScreen: true, aB: true, cD: true })
+})
+
+test('negated option validation', () => {
   const cli = cac()
 
   cli.option('--config <config>', 'config file')