-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Detector Parameters Update: PFRICH #570
Comments
Hi @kkauder, do you have a plan for updating the parameters? |
@Chao1009 Could you tell me what test to run after I make changes and see a new report? |
Also, what's the preferred procedure? Should I hardcode values in https://github.com/eic/epic/blob/main/compact/definitions.xml? Or still use something like the existing
and rely on |
@Chao1009 please check that #595 does what is needed. Two notes:
|
### Briefly, what does this PR introduce? Adjust parameters to conform to https://eic.jlab.org/Geometry/Detector/Detector-20231031150001.html ### What kind of change does this PR introduce? - [ ] Bug fix (issue #570 ) - [ ] New feature (issue #__) - [ ] Documentation update - [ ] Other: __ ### Please check if this PR fulfills the following: - [ ] Tests for the changes have been added - [ ] Documentation has been added / updated - [ ] Changes have been communicated to collaborators ### Does this PR introduce breaking changes? What changes might users need to make to their code? The volume is shortened, the inner radius enlarged, so in general no problems expected. But it's also shifted by 1mm toward 0, so other systems need to respect the change in `CentralTrackingRegionN_zmax` to avoid overlap. ### Does this PR change default behavior? Yes
A series of smaller issues from #552
det
: new value from 2023/09/27 parameter tablesim
: current simulation value as of 2023/10/11template_var
: from which we extract the sim value in compact files.Empty
means we do not know.stat
:Correct
,Missing
, orMismatched
Please implement the new detector parameters, and try to fill in the
template_var
for theMissing
ones if you think it's important for future simulation/design comparison.Here is the detailed report for this detector subsystem:
The text was updated successfully, but these errors were encountered: