-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Detector Parameters Update: Hadron Endcap EMCal #571
Comments
For the Outer Radius, 174 cm should be the correct value and we should change the table. I am not quite sure about the Inner Radius and I assigned @rymilton for a review. I will modify the Physical Start and End later. |
The EcalEndcapP_rmin variable in the simulation doesn't actually have any impact on the size of the Ecal. Instead, there's a 60x60 cm square hole cut out where the Ecal insert is placed. So for the inner radius of the Ecal, we can just use the radius of the hole in the ECal insert, which is 14.61 cm. |
@jizhongling, please contact Tanja (https://eic.jlab.org/Geometry) if you have any questions about the detector parameters. Do you plan to update the other parameters? |
I think @wdconinc will summarize many changes by an email. |
Do you mean @sly2j ? |
Yes. Thanks. |
…600) ### Briefly, what does this PR introduce? The latest table https://eic.jlab.org/Geometry/Detector/Detector-20231031150001.html has a shorter service gap. This should have a knock-on effect on all forward detectors that ultimately depend on `ForwardServiceGap_zmin` ### What kind of change does this PR introduce? - [x] Bug fix (issue #572 , #571 , possibly more) - [ ] New feature (issue #__) - [ ] Documentation update - [ ] Other: __ ### Please check if this PR fulfills the following: - [ ] Tests for the changes have been added - [ ] Documentation has been added / updated - [ ] Changes have been communicated to collaborators ### Does this PR introduce breaking changes? What changes might users need to make to their code? No ### Does this PR change default behavior? Yes
After discussions, the outer radius will be changed to the current Table value (195 cm) in this PR: #602 |
A series of smaller issues from #552
det
: new value from 2023/09/27 parameter tablesim
: current simulation value as of 2023/10/11template_var
: from which we extract the sim value in compact files.Empty
means we do not know.stat
:Correct
,Missing
, orMismatched
Please implement the new detector parameters, and try to fill in the
template_var
for theMissing
ones if you think it's important for future simulation/design comparison.Here is the detailed report for this detector subsystem:
The text was updated successfully, but these errors were encountered: