-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Detector Parameters Update: Hadron Endcap HCal #572
Comments
Hi, the hadron endcap HCal is not my detector. I am the liaison for the insert (which is not in the detector parameters spreadsheet for some reason). The ORNL folks are leading the HCal/LFHCAL. |
Hi @FriederikeBock, would you plan to verify and update the related detector parameters in the simulation? Please let us know if you have any questions or need help. |
@Chao1009 I'm not so sure how to help here.
z min and max are defined via other detector parameters. So it seems someone is going beyond their allotted volume ahead of the LFHCal.
Even if it should not affect us entirely, as our detector is not defined as a disc but rather as single placement of 8M modules. That's why I also didn't define an inner radius, as I can't. Not sure whether this is really helpful. |
@Chao1009 @FriederikeBock , I chased it down to |
…600) ### Briefly, what does this PR introduce? The latest table https://eic.jlab.org/Geometry/Detector/Detector-20231031150001.html has a shorter service gap. This should have a knock-on effect on all forward detectors that ultimately depend on `ForwardServiceGap_zmin` ### What kind of change does this PR introduce? - [x] Bug fix (issue #572 , #571 , possibly more) - [ ] New feature (issue #__) - [ ] Documentation update - [ ] Other: __ ### Please check if this PR fulfills the following: - [ ] Tests for the changes have been added - [ ] Documentation has been added / updated - [ ] Changes have been communicated to collaborators ### Does this PR introduce breaking changes? What changes might users need to make to their code? No ### Does this PR change default behavior? Yes
A series of smaller issues from #552
det
: new value from 2023/09/27 parameter tablesim
: current simulation value as of 2023/10/11template_var
: from which we extract the sim value in compact files.Empty
means we do not know.stat
:Correct
,Missing
, orMismatched
Please implement the new detector parameters, and try to fill in the
template_var
for theMissing
ones if you think it's important for future simulation/design comparison.Here is the detailed report for this detector subsystem:
The text was updated successfully, but these errors were encountered: