Added issue and PR templates #160
Conversation
Created templates for issues and pull requests, as per issue eiffel-community#159. The intention is for these templates to be minimalistic and easy to use, yet guide contributors towards including sufficient information so as to enable effective discussions and reviews. The templates are intended to reflect the contribution guidelines, while aligning to generally accepted good practice.
There was a problem hiding this comment.
Other open source projects requires you to explicitly "sign-off" your contribution, example:
https://git.eclipse.org/r/Documentation/user-signedoffby.html
Is that something to consider also for Eiffel?
I guess that the sign-off principle is something that is there for legal reasons.
|
I actually don't think that's necessary in this case (and I'm reluctant to add anything that isn't necessary). The signed-off-by process is typically used in contexts, as the description you linked, for "patches that are being emailed around". I believe we achieve sufficient records through GitHub by using issue references. |
|
I don't like unnecessary things either. And legal aspects are not too much fun.. |
|
Fair enough, better safe than sorry :) |
Created templates for issues and pull requests, as per issue #159.
The intention is for these templates to be minimalistic and easy
to use, yet guide contributors towards including sufficient
information so as to enable effective discussions and reviews.
The templates are intended to reflect the contribution guidelines,
while aligning to generally accepted good practice.