TERCC: Add UUID validation pattern to links.target #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The TERCC event's validation pattern for links.target disappeared in 2.0.0 of the event which no doubt must've been a mistake. Introduce 4.1.1 to fix this bug and align TERCC with all other event types.
t-persson
approved these changes
Sep 20, 2021
e-backmark-ericsson
approved these changes
Sep 20, 2021
There was a problem hiding this comment.
This is actually a non-backwards compatible change in the json schema, as we restrict the value range for the target uuid field, so the version should be stepped by it's major component. But I'd say we can consider it defacto backwards compatible, as I have a very hard time seeing that anyone would have misused the possibility to state anything else than a uuid there, so I'd say it is ok to make this a patch version update.
|
Technically yes, but I'd argue that bugfixes of this kind are still bugfixes even if they theoretically break someone's spacebar heating. The rest of the spec (e.g. the-links-object.md) says UUID for all event types. |
e-backmark-ericsson
pushed a commit
to e-backmark-ericsson/eiffel
that referenced
this pull request
Apr 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applicable Issues
Fixes #271
Description of the Change
The TERCC event's validation pattern for links.target disappeared in 2.0.0 of the event which no doubt must've been a mistake. Introduce 4.1.1 to fix this bug and align TERCC with all other event types.
Here's the diff between 4.1.0 and 4.1.1:
Alternate Designs
None.
Benefits
TERCC enforces UUIDs for link targets just like all other events.
Possible Drawbacks
None.
Sign-off
Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or
(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or
(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.
(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved.
Signed-off-by: Magnus Bäck <magnus.back@axis.com>