I don't think we need to scream #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed typo.
Why SHOULD we scream?
|
Where defining explicit rules, SHOULD, SHALL and MAY are consistently capitalized throughout the documentation to emphasize their role as key words. This is common convention in specifications, see e.g. https://tools.ietf.org/html/rfc2119 |
|
... or at least they SHOULD be thus emphasized :) |
|
Ok, I'll not argue against that. It just feels weird, but I'll bury my axe. Still the typo is there :) |
Reverted the non-screaming change. Only the typo is left.
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like SHOULD to be changed to should, since I see no point in screaming in the documentation.
Also, a small typo was fixed.