Skip to content

Conversation

andmat900
Copy link
Contributor

@andmat900 andmat900 commented Jan 10, 2025

Applicable Issues

Related PR

Description of the Change

This change removes the old unused labels id and app from the testrun controller.

Alternate Designs

Possible Drawbacks

Sign-off

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or

(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or

(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.

(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.

Signed-off-by: Andrei Matveyeu, andrei.matveyeu@axis.com

@andmat900 andmat900 requested a review from a team as a code owner January 10, 2025 12:19
@andmat900 andmat900 requested review from t-persson and fredjn and removed request for a team January 10, 2025 12:19
Copy link
Collaborator

@t-persson t-persson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please identify and fix all places where ETOS assumes that the "id" and "app" are set.

@andmat900
Copy link
Contributor Author

andmat900 commented Jan 15, 2025

Please identify and fix all places where ETOS assumes that the "id" and "app" are set.

The only place I was able to identify is the PR mentioned above: eiffel-community/etos-api#97
Do you see more?

@t-persson
Copy link
Collaborator

Please identify and fix all places where ETOS assumes that the "id" and "app" are set.

The only place I was able to identify is the PR mentioned above: eiffel-community/etos-api#97 Do you see more?

https://github.com/eiffel-community/etos-api/blob/main/python/src/etos_api/routers/v0/router.py#L201-L202

@andmat900
Copy link
Contributor Author

Please identify and fix all places where ETOS assumes that the "id" and "app" are set.

The only place I was able to identify is the PR mentioned above: eiffel-community/etos-api#97 Do you see more?

https://github.com/eiffel-community/etos-api/blob/main/python/src/etos_api/routers/v0/router.py#L201-L202

All should be fixed by now.

@andmat900 andmat900 requested a review from t-persson February 3, 2025 11:26
@andmat900 andmat900 merged commit 0625c07 into eiffel-community:main Feb 3, 2025
andmat900 added a commit to andmat900/etos that referenced this pull request Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants