Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Biobank and PatientRegistry as disjoint sub-types of Resource #58

Closed
luizbonino opened this issue Aug 25, 2023 · 2 comments
Closed

Biobank and PatientRegistry as disjoint sub-types of Resource #58

luizbonino opened this issue Aug 25, 2023 · 2 comments
Assignees

Comments

@luizbonino
Copy link
Member

During the L1/L2 meeting an issue was raised concerning resources that present themselves as both Biobank and PatientRegistry. In the group's discussion, we concluded that a given resource should only be declared as one of these types, not both. Although in the metadata schema they have the same set of properties, these entities are of different nature. Naturally, a biobank (or multiple) and a patient registry (or multiple) can be managed by or belong to a single organisation. However, we consider that the focus of EJP-RD is on the informational resources and not on the organisations managing them.

The request is to make clear that these sub-classes are disjoint in the diagram, related ontology and documentation.

@henrietteharmse
Copy link
Contributor

@luizbonino Should the disjointness statement include Guideline, Dataset and DataService since they as well extend Resources? In general classes in a UML class diagram are considered to be disjoint. This was also the case for generalizations, but that seemed to have changed from UML 2.5.0, which I did not realize.

henrietteharmse added a commit that referenced this issue Aug 29, 2023
…licit. There is no disjointness between Dataset and DataSerive in DCATv2. #58
@luizbonino
Copy link
Member Author

Thanks Henriette. Yes, until UML 2.4.1, generalisation sets were incomplete and disjoint by default. In UML 2.5 they changed the defaults to incomplete and overlapping.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants