Complete variant for the elastic agent is not generating the right binaries

[mdelapenya]

When running mage package, the binaries generated by the elastic-agent are incorrect:

• there are three variants: "default", ubi8 and complete.
• the docker image for the ubi8 variant is properly generated under build/distributions
• the docker image for the complete variant is generated under build/distributions, BUT overriding the default image.

I suspect that this has been caused by #27350 and #27052

Steps to reproduce

1. Run cd x-pack/elastic-agent
2. Run PLATFORMS="linux/amd64" mage package (Narrowing down the process to build only one platform)
3. Wait for the process to finish... (10 min?)

Expected behaviour

Three docker image binaries are generated, one per variant (default, ubi8 and complete), being the complete one the heaviest in weight (contains node runtime plus libs).

$ ls -l x-pack/elastic-agent/build/distributions | grep docker
-rw-r--r--  1 mdelapenya  staff  244359238 26 Aug 13:51 elastic-agent-8.0.0-linux-amd64.docker.tar.gz
-rw-r--r--  1 mdelapenya  staff        175 26 Aug 13:51 elastic-agent-8.0.0-linux-amd64.docker.tar.gz.sha512
-rw-r--r--  1 mdelapenya  staff  614539725 26 Aug 13:55 elastic-agent-complete-8.0.0-linux-amd64.docker.tar.gz
-rw-r--r--  1 mdelapenya  staff        184 26 Aug 13:56 elastic-agent-complete-8.0.0-linux-amd64.docker.tar.gz.sha512
-rw-r--r--  1 mdelapenya  staff  163226167 26 Aug 13:50 elastic-agent-ubi8-8.0.0-linux-amd64.docker.tar.gz
-rw-r--r--  1 mdelapenya  staff        180 26 Aug 13:50 elastic-agent-ubi8-8.0.0-linux-amd64.docker.tar.gz.sha512

When you docker load the default image, the default image is loaded into the Docker engine:

$ docker load -i x-pack/elastic-agent/build/distributions/elastic-agent-8.0.0-linux-amd64.docker.tar.gz 
Loaded image: docker.elastic.co/beats/elastic-agent:8.0.0

Current behaviour

Two docker image binaries are generated, one per variant (default and ubi8, only).

$ ls -l x-pack/elastic-agent/build/distributions | grep docker
-rw-r--r--   1 mdelapenya  staff  608875722 26 Aug 12:57 elastic-agent-8.0.0-linux-amd64.docker.tar.gz
-rw-r--r--   1 mdelapenya  staff        175 26 Aug 12:58 elastic-agent-8.0.0-linux-amd64.docker.tar.gz.sha512
-rw-r--r--   1 mdelapenya  staff  163226167 26 Aug 12:56 elastic-agent-ubi8-8.0.0-linux-amd64.docker.tar.gz
-rw-r--r--   1 mdelapenya  staff        180 26 Aug 12:56 elastic-agent-ubi8-8.0.0-linux-amd64.docker.tar.gz.sha512

When you docker load the default image, the complete image is loaded into the Docker engine:

$ docker load -i x-pack/elastic-agent/build/distributions/elastic-agent-8.0.0-linux-amd64.docker.tar.gz 
Loaded image: docker.elastic.co/beats/elastic-agent-complete:8.0.0

[elasticmachine]

Pinging @elastic/uptime (Team:Uptime)

[elasticmachine]

Pinging @elastic/agent (Team:Agent)

[mdelapenya]

I'm currently sending a fix, as I reproduced and fixed it locally

[mdelapenya]

What surprises me even more is that the unified release process does contain the three artifacts: https://artifacts-api.elastic.co/v1/search/8.0.0-SNAPSHOT/elastic-agent?x-elastic-no-kpi=true

If you wget the elastic-agent default image, and then docker.load it, then you'll have the default image loaded in your Docker engine. cc/ @elastic/observablt-robots

[andrewvc]

Hmmm, running mage package on my machine I get images that look correct in terms of sizes. This issue looks to be about the tar.gz files which I did not test. I'll look into that next

docker.elastic.co/beats/elastic-agent-complete   8.0.0                     4cb35ae0f32a   About an hour ago   1.55GB
docker.elastic.co/beats/elastic-agent-ubi8       8.0.0                     92579b6d4741   About an hour ago   298MB
docker.elastic.co/beats/elastic-agent            8.0.0                     748b00424478   About an hour ago   522MB

[mdelapenya]

Yep, docker images seem correct. I found the issue in the tar.gz representation of the docker images.

[andrewvc]

@mdelapenya see my fix here: #27621 , I'd appreciate a review if possible. It works locally!

[justinkambic]

Post FF testing LGTM