Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add -buildmode=pie for supported platform #24964

Merged
merged 2 commits into from
Apr 12, 2021
Merged

Conversation

urso
Copy link

@urso urso commented Apr 7, 2021

  • Enhancement

What does this PR do?

Add -buildmode=pie CLI flag to go build when compiling for platforms that support position independent code.

Why is it important?

Go 1.15 already enabled

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
    - [ ] I have made corresponding changes to the documentation
    - [ ] I have made corresponding change to the default configuration files
    - [ ] I have added tests that prove my fix is effective or that my feature works
    - [ ] I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Apr 7, 2021
@urso urso added the Team:Elastic-Agent Label for the Agent team label Apr 7, 2021
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Apr 7, 2021
@elasticmachine
Copy link
Collaborator

elasticmachine commented Apr 7, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: urso commented: /test

  • Start Time: 2021-04-12T12:07:33.560+0000

  • Duration: 10 min 35 sec

  • Commit: 142493c

Trends 🧪

Image of Build Times

❕ Flaky test report

No test was executed to be analysed.

@urso urso marked this pull request as ready for review April 7, 2021 14:49
@elasticmachine
Copy link
Collaborator

Pinging @elastic/agent (Team:Agent)

@urso urso requested a review from andrewkroh April 7, 2021 14:50
@ph
Copy link
Contributor

ph commented Apr 7, 2021

/package

Copy link
Contributor

@blakerouse blakerouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good, just a miss spelling in docstring.

dev-tools/mage/build.go Outdated Show resolved Hide resolved
Copy link
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@urso
Copy link
Author

urso commented Apr 8, 2021

/test

@urso urso added the backport-v7.13.0 Automated backport with mergify label Apr 8, 2021
@urso
Copy link
Author

urso commented Apr 12, 2021

/test

@urso urso merged commit 1c49866 into elastic:master Apr 12, 2021
@urso urso deleted the buildmode-pie branch April 12, 2021 13:49
@tonymeehan
Copy link
Contributor

YAY! THANK YOU.

@urso urso added the needs_backport PR is waiting to be backported to other branches. label Apr 12, 2021
mergify bot pushed a commit that referenced this pull request Apr 12, 2021
urso pushed a commit that referenced this pull request Apr 13, 2021
(cherry picked from commit 1c49866)

Co-authored-by: Steffen Siering <steffen.siering@elastic.co>
v1v added a commit to v1v/beats that referenced this pull request Apr 14, 2021
* upstream/master: (308 commits)
  [winlogbeat] Add support for sysmon v13 events 24 and 25 (elastic#24945)
  mergify: add backport label (elastic#25050)
  Add pod.ip in k8s metadata (elastic#25037)
  [elastic-agent] Use fleet.url for container cmd (elastic#25026)
  disable TestXPackEnabled flaky test in logstash metricbeat module (elastic#25034)
  Leverege leader election in agent  k8s manifests (elastic#25016)
  libbeat/publisher/pipeline: expand monitoring (elastic#24700)
  libbeat: fix decode_json_fields config validation (elastic#24862)
  Remove make docs-preview instructions (elastic#25001)
  [Filebeat] Fix IPtables pipeline (elastic#24928)
  [DOCS] cd into correct directory before invoking mage. (elastic#17679)
  Add -buildmode=pie for supported platform (elastic#24964)
  Add agent's direcotry in k8s manifest generator (elastic#24987)
  [mergify] assign the original author (elastic#25007)
  Fix AWS module flaky tests (elastic#24852)
  [filebeat] Use fail_on_template_error on google_workspace and okta pagination (elastic#24967)
  Updated config to match defaults (elastic#25004)
  [Filebeat] Fix hardcoded amazonaws.com endpoint (elastic#24861)
  Add cloud.service.name to add_cloud_metadata (elastic#24993)
  [Ingest Manager] Expose processes and their metrics (elastic#24788)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v7.13.0 Automated backport with mergify needs_backport PR is waiting to be backported to other branches. Team:Elastic-Agent Label for the Agent team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use -buildmode=pie (position independence executable)
6 participants