Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add workaround for expried GPG keys for auditbeat packaging #33915

Merged
merged 1 commit into from
Dec 1, 2022
Merged

Add workaround for expried GPG keys for auditbeat packaging #33915

merged 1 commit into from
Dec 1, 2022

Conversation

rdner
Copy link
Member

@rdner rdner commented Dec 1, 2022 •
edited
Loading

It's using Debian Wheezy which has expired GPG keys, we need additional flags in order to package auditbeat now.

Why is it important?

So, the packaging job would not fail like this one https://beats-ci.elastic.co/blue/organizations/jenkins/Beats%2Fpackaging/detail/PR-33843/10/pipeline/141/

@rdner rdner added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label Dec 1, 2022
@rdner rdner self-assigned this Dec 1, 2022
@rdner rdner requested a review from a team as a code owner December 1, 2022 12:33
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Dec 1, 2022
@rdner rdner mentioned this pull request Dec 1, 2022
Merged
@rdner
Add workaround for expried GPG keys for auditbeat packaging
6f01941 
It's using Debian Wheezy which has expired GPG keys, we need
additional flags in order to package auditbeat now.
@rdner rdner force-pushed the handle-expired-gpg-auditbeat branch from 99e11b5 to 6f01941 Compare December 1, 2022 12:35
@rdner rdner requested review from cmacknz and removed request for a team December 1, 2022 12:36
@rdner rdner added the forwardport-main Automated forwardport with mergify label Dec 1, 2022
@rdner
Copy link
Member Author

rdner commented Dec 1, 2022

@cmacknz turns out Auditbeat has its own packaging implementation in its magefile, I missed this in #33895

@sonarcloud
Copy link

sonarcloud bot commented Dec 1, 2022

Please retry analysis of this Pull-Request directly on SonarCloud.

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-12-01T12:35:49.343+0000

  • Duration: 36 min 32 sec

Test stats 🧪

Test Results
Failed 0
Passed 261
Skipped 33
Total 294

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@rdner rdner merged commit a228948 into elastic:7.17 Dec 1, 2022
@rdner rdner deleted the handle-expired-gpg-auditbeat branch December 1, 2022 13:11
mergify bot pushed a commit that referenced this pull request Dec 1, 2022
@rdner @mergify
Add workaround for expried GPG keys for auditbeat packaging (#33915)
3231552 
It's using Debian Wheezy which has expired GPG keys, we need
additional flags in order to package auditbeat now.

(cherry picked from commit a228948)

# Conflicts:
#	x-pack/auditbeat/magefile.go
@mergify mergify bot mentioned this pull request Dec 1, 2022
Closed
@rdner
Copy link
Member Author

rdner commented Dec 1, 2022

Interesting. I found this PR with a backport 7.17 but it was not backported eventually because of some compatibility issues #23872

That's why 7.17 has this issue.

@cmacknz
Copy link
Member

cmacknz commented Dec 1, 2022

Good find, FYI @v1v. Thanks for following up on this Denis.

@rdner rdner mentioned this pull request Mar 24, 2023
Closed
rdner added a commit to rdner/beats that referenced this pull request Mar 24, 2023
@rdner
Force install dependencies in old Debian with expired keys
e407fc1 
This change is the same as elastic#33915
but for the rest of the Beats.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmacknz cmacknz Awaiting requested review from cmacknz

Assignees

@rdner rdner

Labels
forwardport-main Automated forwardport with mergify Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rdner @elasticmachine @cmacknz