Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

filebeat/input/{tcp,udp}: add support for IPv6 interface metrics #35123

Merged
merged 1 commit into from
Apr 20, 2023
Merged

filebeat/input/{tcp,udp}: add support for IPv6 interface metrics #35123

merged 1 commit into from
Apr 20, 2023

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Apr 19, 2023 •
edited
Loading

What does this PR do?

This adds support for collecting TCP and UDP sytem metrics for IPv6 traffic. The metrics from the two families are aggregated into to a single value.

It also fixes base for parsing values from /proc/net tables with provenance for the base.

Why is it important?

Users may be using IPv6 stacks and the current value parsing is incorrect.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • Query here whether the IPv4 and IPv6 stats should be separated. I don't think that this is particularly informative for the uses that we have, in examining disparity between upstream flow and our throughput. For users I suppose it may be interesting, but probably not very.

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@efd6 efd6 requested a review from a team as a code owner April 19, 2023 02:52
@efd6 efd6 self-assigned this Apr 19, 2023
@efd6 efd6 requested review from belimawr and leehinman and removed request for a team April 19, 2023 02:52
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Apr 19, 2023
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Apr 19, 2023
@efd6 efd6 requested a review from a team April 19, 2023 02:53
@efd6 efd6 force-pushed the 35111-v6-metrics branch 2 times, most recently from ac7b074 to 8f9d143 Compare April 19, 2023 03:25
@elasticmachine
Copy link
Collaborator

elasticmachine commented Apr 19, 2023 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-04-19T04:34:55.301+0000

  • Duration: 71 min 52 sec

Test stats 🧪

Test Results
Failed 0
Passed 7691
Skipped 753
Total 8444

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@efd6
filebeat/input/{tcp,udp}: add support for IPv6 interface metrics
385ad6e 
Also fix base for parsing values from /proc/net tables.
leehinman
leehinman approved these changes Apr 19, 2023
View reviewed changes
Copy link
Contributor

@leehinman leehinman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@efd6 efd6 merged commit 9807be1 into elastic:main Apr 20, 2023
mergify bot pushed a commit that referenced this pull request Apr 20, 2023
@efd6 @mergify
filebeat/input/{tcp,udp}: add support for IPv6 interface metrics (#35123
2f83b12 
)

Also fix base for parsing values from /proc/net tables.

(cherry picked from commit 9807be1)
@mergify mergify bot mentioned this pull request Apr 20, 2023
Merged
efd6 added a commit that referenced this pull request Apr 20, 2023
@mergify @efd6
[8.7](backport #35123) filebeat/input/{tcp,udp}: fix metric parsing b…
e2dade6 
…ase (#35136)

* filebeat/input/{tcp,udp}: fix base for parsing values from /proc/net tables (#35123)

(cherry picked from commit 9807be1)

* back out non-bugfix changes

---------

Co-authored-by: Dan Kortschak <90160302+efd6@users.noreply.github.com>
Co-authored-by: Dan Kortschak <dan.kortschak@elastic.co>
chrisberkhout pushed a commit that referenced this pull request Jun 1, 2023
@efd6 @chrisberkhout
filebeat/input/{tcp,udp}: add support for IPv6 interface metrics (#35123
36e7f61 
)

Also fix base for parsing values from /proc/net tables.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leehinman leehinman leehinman approved these changes

@belimawr belimawr Awaiting requested review from belimawr belimawr is a code owner automatically assigned from elastic/elastic-agent-data-plane

Assignees

@efd6 efd6

Labels
8.8-candidate backport-v8.7.0 Automated backport with mergify bugfix enhancement Filebeat Filebeat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@efd6 @elasticmachine @leehinman