-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
filebeat: Fix flaky test case on macOS #39860
filebeat: Fix flaky test case on macOS #39860
Conversation
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A general question: Do we need those tests using the FQDN? Could we just disable it as those tests are not testing the FQDN and have the suit run faster?
Hmm, I'm not sure if we can selectively disable FQDN. These integration test cases try to run the |
The Elastic-Agent has got a flag to select if we're using FQDN or not, I don't fully recall how that works for a standalone Beat, it might be possible. But if the OS is slow to respond regardless of how we query it, then there is not much we can do. Anyway, the PR looks good now! |
* fix: fix a flaky test on macos * fix: fix more such test cases * fix: only update ignore_older * fix: also fix flaky test_restart_state * fix: fix CI (cherry picked from commit f9fec1e)
* fix: fix a flaky test on macos * fix: fix more such test cases * fix: only update ignore_older * fix: also fix flaky test_restart_state * fix: fix CI (cherry picked from commit f9fec1e) Co-authored-by: VihasMakwana <121151420+VihasMakwana@users.noreply.github.com>
Proposed commit message
This PR fixes following test cases which are flaky for macOS:
On MacOS, the FQDN lookup takes some time (~5 seconds) before signal handlers are set up
To make sure that the tests are passed, we need to increase the timeout by few seconds in each of the failing cases.
You can view the full discussion https://elastic.slack.com/archives/C047NDNGUMU/p1717091056290869.
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Fixes #39613