-
Notifications
You must be signed in to change notification settings - Fork 43
[CSPM] Align rule fields with ECS schema #3189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This pull request does not have a backport label. Could you fix it @kubasobon? 🙏
|
if !ok { | ||
return errors.New("could not cast rule to 'evaluator.Rule") | ||
} | ||
rule.UUID = rule.Id |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think we should also make rule.Id
be rule.benchmark.rule_number
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rule.Id
is something like cb57543f-5435-55b5-97cf-bda29ec9094a
for CIS AWS 1.10 rule.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! I liked the choice of using a data provider enrichment
(cherry picked from commit 5ce363f)
Summary of your changes
Screenshot/Data
Related Issues
Checklist
Introducing a new rule?