Skip to content

Conversation

kubasobon
Copy link
Member

@kubasobon kubasobon commented Apr 14, 2025

Summary of your changes

Screenshot/Data

Related Issues

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary README/documentation (if appropriate)

Introducing a new rule?

@kubasobon kubasobon self-assigned this Apr 14, 2025
Copy link

mergify bot commented Apr 14, 2025

This pull request does not have a backport label. Could you fix it @kubasobon? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 8./d branch. /d is the digit
  • backport-active-all is the label that automatically backports to all active branches.
  • backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
  • backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.
    NOTE: backport-v8.x has been added to help with the transition to the new branch 8.x.

@kubasobon kubasobon marked this pull request as ready for review April 15, 2025 16:21
@kubasobon kubasobon requested a review from a team as a code owner April 15, 2025 16:21
@oren-zohar oren-zohar requested a review from orouz April 16, 2025 11:38
if !ok {
return errors.New("could not cast rule to 'evaluator.Rule")
}
rule.UUID = rule.Id
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think we should also make rule.Id be rule.benchmark.rule_number?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rule.Id is something like cb57543f-5435-55b5-97cf-bda29ec9094a for CIS AWS 1.10 rule.

Copy link
Contributor

@eyalkraft eyalkraft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I liked the choice of using a data provider enrichment

@kubasobon kubasobon enabled auto-merge (squash) May 9, 2025 09:02
@kubasobon kubasobon merged commit 5ce363f into main May 9, 2025
9 checks passed
@kubasobon kubasobon deleted the ecs-rule-update branch May 9, 2025 09:19
mergify bot pushed a commit that referenced this pull request May 9, 2025
kubasobon added a commit that referenced this pull request May 27, 2025
[CSPM] Align rule fields with ECS schema (#3189)

(cherry picked from commit 5ce363f)

Co-authored-by: Kuba Soboń <wtty.fool@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants