Skip to content

Conversation

Mpdreamz
Copy link
Member

@Mpdreamz Mpdreamz commented Jun 23, 2025

We need to do this on both branches as otherwise it requires a certain order for phantom branches to not be validated.

Fixes: https://github.com/elastic/elastic-otel-node/actions/runs/15825603447/job/44606696330

The check was failing unrelated to anything elastic-otel-node. Our check relied on elasticsearch://reference being checked before docs-content://reference but in the current iteration of the links.json checks this did not happen because our dictionaries are unordered (as they should be).

…solution.

We need to do this on both branches as otherwise it requires a certain order for phantom branches to not be validated.
@Mpdreamz Mpdreamz requested a review from a team as a code owner June 23, 2025 15:20
@Mpdreamz Mpdreamz added the fix label Jun 23, 2025
@Mpdreamz Mpdreamz self-assigned this Jun 23, 2025
@Mpdreamz Mpdreamz added the fix label Jun 23, 2025
@Mpdreamz Mpdreamz merged commit b7560ba into main Jun 23, 2025
17 checks passed
@Mpdreamz Mpdreamz deleted the fix/validation-phantoms branch June 23, 2025 16:49
@theletterf
Copy link
Contributor

@cotti @Mpdreamz Seems like the problem now cascades down one step:

Error: 'elasticsearch' defines: 'reference/' that 'docs-content://reference/index.md resolving to '/docs/reference/' conflicts with 

	The following errors and warnings were found in the documentation

Error: 'elasticsearch' defines: 'reference/' that 'docs-content://reference/index.md resolving to '/docs/reference/' conflicts with 
NOTE: docs-content

See #1385

@Mpdreamz
Copy link
Member Author

That PR is out of date, needs an update :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants