Skip to content

Update NavigationPrefixChecker to skip phantom paths during link resolution. #1418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 23, 2025
Merged

Update NavigationPrefixChecker to skip phantom paths during link resolution. #1418

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/tooling/docs-assembler/Links/NavigationPrefixChecker.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ private async Task FetchAndValidateCrossLinks(DiagnosticsCollector collector, st

// Todo publish all relative folders as part of the link reference
// That way we don't need to iterate over all links and find all permutations of their relative paths
foreach (var (relativeLink, _) in linkReference.Links)
foreach (var (relativeLink, linkMetadata) in linkReference.Links)
{
var navigationPaths = _uriResolver.ResolveToSubPaths(new Uri($"{repository}://{relativeLink}"), relativeLink);
foreach (var navigationPath in navigationPaths)
Expand All @@ -116,6 +116,9 @@ private async Task FetchAndValidateCrossLinks(DiagnosticsCollector collector, st
}
else
{
if (_phantoms.Count > 0 && _phantoms.Contains(new Uri($"{repository}://{navigationPath}")))
continue;

dictionary.Add(navigationPath, new SeenPaths
{
Repository = repository,
Expand Down
Loading