Implement breadcrumbs fixes #138

[Mpdreamz]

No description provided.

[bmorelli25]

Looks good! Definitely good enough for MVP. A few thoughts, likely for a future enhancement issue:

• We should figure out the approach we want to take with deeply nested/long heading pages. I think a scroll is fine for now, but we likely want to do something different in the long run.

• We probably want to use navigation_title for both the TOC and the Breadcrumbs. This will greatly reduce the length of some of our longer breadcrumb sequences and allow us to prioritize SEO without worrying about the length of page titles. It also creates a visual mapping between breadcrumb/TOC heading.

• A lot of breadcrumbs omit the current page you're on. This reduces duplication and further shortens long breadcrumb sequences. For example, instead of this:
  

  We can do this:
  

Again, I don't think any of this needs to be addressed in this PR. Weigh the amount of effort required vs opening an issue and adding these enhancements later. I think what you have here is great for MVP.

[Mpdreamz]

Those are great points and except for the first one quick wins, will amend in the morning!

[reakaleek]

Do you think a test for this could be beneficial?

[Mpdreamz]

Do you think a test for this could be beneficial?

yes! good call calling out my laziness 😸

[reakaleek]

nit: I think another critical path worth testing is if the page has 0 parents. Nevertheless, thank you for adding a test!

[Mpdreamz]

++ will follow up at some point!