Skip to content

applies_to: Show GA in "Planned" if technical preview exists #1492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 2, 2025
Merged

applies_to: Show GA in "Planned" if technical preview exists #1492

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b8c05a7
applies_to: Show GA in "Planned" if technical preview exists
reakaleek Jul 1, 2025
fdb987c
Add test
reakaleek Jul 1, 2025
75ca1bb
Refactor
reakaleek Jul 1, 2025
38d5cca
Also add beta into the condition
reakaleek Jul 2, 2025
d840dc4
Merge branch 'main' into feature/show-ga-when-technical-preview-exists
reakaleek Jul 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Elastic.Markdown/Myst/Components/ApplicableToComponent.cshtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,7 +272,7 @@
case ProductLifecycle.GenerallyAvailable:
if (TryGetRealVersion(applicability, out var version) && version > versioningSystem.Current)
{
badgeText = "Planned";
badgeText = applications.Any(a => a.Lifecycle is ProductLifecycle.TechnicalPreview or ProductLifecycle.Beta) ? "GA planned" : "Planned";
lifecycleTooltip = "We plan to add this functionality in a future update. Plans may change without notice.";
lifecycleClass = "planned";
}
Expand Down
41 changes: 41 additions & 0 deletions tests/authoring/Inline/AppliesToRole.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,3 +121,44 @@ type ``parses multiple applies_to in one line`` () =
Ece=AppliesCollection.op_Explicit "removed"
)
))

type ``render 'GA Planned' if preview exists alongside ga`` () =
static let markdown = Setup.Markdown """

This is an inline {applies_to}`stack: preview 9.0, ga 9.1` element.
"""

[<Fact>]
let ``parses to AppliesDirective`` () =
let directives = markdown |> converts "index.md" |> parses<AppliesToRole>
test <@ directives.Length = 1 @>
directives |> appliesToDirective (ApplicableTo(
Stack=AppliesCollection.op_Explicit "preview 9.0, ga 9.1"
))

[<Fact>]
let ``validate HTML: generates link and alt attr`` () =
markdown |> convertsToHtml """
<p>This is an inline
<span class="applies applies-inline">
<span class="applicable-info">
<span class="applicable-name" data-tippy-content="Part of the versioned Elastic Stack

Available in ECH, ECE, ECK, and self-managed deployments, unless otherwise stated">Stack</span>
<span class="applicable-separator"></span>
<span class="applicable-meta applicable-meta-planned" data-tippy-content="We plan to add this functionality in a future update. Plans may change without notice.">
Planned
</span>
</span>
<span class="applicable-info">
<span class="applicable-name" data-tippy-content="Part of the versioned Elastic Stack

Available in ECH, ECE, ECK, and self-managed deployments, unless otherwise stated">Stack</span>
<span class="applicable-separator"></span>
<span class="applicable-meta applicable-meta-planned" data-tippy-content="We plan to add this functionality in a future update. Plans may change without notice.">
GA planned
</span>
</span>
</span>
element.</p>
"""
Loading