Skip to content

Conversation

reakaleek
Copy link
Member

@reakaleek reakaleek commented Jul 2, 2025

So we can ignore some files and so that the files are not included in the comment.
(I'm not 100% sure if the files will actually be excluded from the changed_files output. But that is my assumption)

So we can ignore some files and so that the files are not included in the comment
@reakaleek reakaleek requested a review from a team as a code owner July 2, 2025 07:46
@reakaleek reakaleek requested a review from leemthompo July 2, 2025 07:46
@reakaleek reakaleek self-assigned this Jul 2, 2025
@reakaleek reakaleek added the automation packaging, ci/cd. label Jul 2, 2025
@leemthompo
Copy link
Contributor

To be explicit, I know I want to ignore the following in the elasticsearch repo:

@reakaleek
Copy link
Member Author

To be explicit, I know I want to ignore the following in the elasticsearch repo:

Then you could use:

with:
  path-pattern-ignore: docs/reference/query-languages/esql/kibana/**/README.md

@leemthompo
Copy link
Contributor

leemthompo commented Jul 2, 2025

Sorry it's two separate things:

Because we're doing this centrally I assumed you'd have to do it all in one place, how would we configure this per repo? (forgive me I probably just haven't thought about this enough)

@reakaleek
Copy link
Member Author

Sorry it's two separate things:

Because we're doing this centrally I assumed you'd have to do it all in one place, how would we configure this per repo?

You can change the configuration here: https://github.com/elastic/elasticsearch/blob/main/.github/workflows/docs-build.yml

And then you can actually do:

with:
  path-pattern: docs/**
  path-pattern-ignore: |
    docs/reference/query-languages/esql/kibana/*.md
    docs/**/README.md

@leemthompo
Copy link
Contributor

Ah OK cool, that's perfect thanks @reakaleek 🚀

Copy link
Contributor

@leemthompo leemthompo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@reakaleek reakaleek requested a review from a team as a code owner July 2, 2025 09:47
Copy link

github-actions bot commented Jul 2, 2025

🔍 Preview links for changed docs

@reakaleek
Copy link
Member Author

reakaleek commented Jul 2, 2025

Confirmed ✅:

In e14aedb I modified both
docs/testing/req.md and docs/testing/cross-links.md, while adding path-pattern-ignore: docs/testing/req.md.

Only the docs/testing/cross-links.md appeared in the comment.

image

@reakaleek reakaleek merged commit de35cd5 into main Jul 2, 2025
16 checks passed
@reakaleek reakaleek deleted the feature/add-path-prefix-ignore branch July 2, 2025 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation packaging, ci/cd.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants