Skip to content

Conversation

reakaleek
Copy link
Member

No description provided.

@reakaleek reakaleek requested a review from a team as a code owner July 1, 2025 22:24
Copy link

github-actions bot commented Jul 1, 2025

🔍 Preview links for changed docs:

🔔 The preview site may take up to 3 minutes to finish building. These links will become live once it completes.

Copy link

github-actions bot commented Jul 1, 2025

🔍 Preview links for changed docs

@leemthompo
Copy link
Contributor

@reakaleek this isn't related to this test PR but one thing I've hit in elasticsearch repo is it's a bit greedy: if a README file (example) or some other non-DocsV3 .md file (example) gets edited it will create a URL for that too (which obviously 404s)

So we might need some rules to avoid such cases. Lemme know if want me to open an issue or something :)

@reakaleek
Copy link
Member Author

@reakaleek this isn't related to this test PR but one thing I've hit in elasticsearch repo is it's a bit greedy: if a README file (example) or some other non-DocsV3 .md file (example) gets edited it will create a URL for that too (which obviously 404s)

So we might need some rules to avoid such cases. Lemme know if want me to open an issue or something :)

Did it already happen with the new implementation?

I'm reusing the result from tj-actions/changed-files

And this has the path-prefix ./docs/**

But I did not verify if it actually works.

@leemthompo
Copy link
Contributor

Did it already happen with the new implementation?

no the cases I mentioned were using the old one, but just flagging for visibility :)

@leemthompo
Copy link
Contributor

leemthompo commented Jul 2, 2025

And this has the path-prefix ./docs/**

yeah I guess at least in elasticsearch there's some additional .md files in there that aren't necessarily for our docs, so might need some tweaking, here's where it might get a bit complex to manage centrally 🤷

@reakaleek
Copy link
Member Author

And this has the path-prefix ./docs/**

yeah I guess at least in elasticsearch there's some additional .md files in there that aren't necessarily for our docs, so might need some tweaking, here's where it might get a bit complex to manage centrally 🤷

We can add an additional property called path-prefix-ignore that you can configure.

@reakaleek
Copy link
Member Author

@leemthompo elastic/docs-builder#1499

@reakaleek reakaleek closed this Jul 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants