Skip to content

Revert applies_to in directives design for recognition value #1977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 1, 2025
Merged

Revert applies_to in directives design for recognition value #1977

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
75cfd58
Revert applies_to in directives design for recognition value
reakaleek Oct 1, 2025
597081c
Run prettier
reakaleek Oct 1, 2025
133eff5
Fix tests
reakaleek Oct 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions src/Elastic.Documentation.Site/Assets/markdown/applies-switch.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,22 +13,18 @@
}
}

.applies-item {
& > .applies-switch-label > .applies-item {
@apply cursor-pointer text-inherit;

&:hover {
@apply text-inherit;
}
.applicable-info {
@apply cursor-pointer border-none bg-transparent p-0;

&:not(:last-child):after {
content: ',';
}
@apply cursor-pointer;
}
.applicable-name,
.applicable-meta {
@apply text-base;
@apply text-xs;
}
}

Expand Down
8 changes: 3 additions & 5 deletions src/Elastic.Documentation.Site/Assets/markdown/applies-to.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
}

.applicable-info {
@apply border-grey-20 inline-grid cursor-default grid-cols-[auto_1fr_auto] rounded-full border-[1px] bg-white pt-1.5 pr-3 pb-1.5 pl-3;
@apply border-grey-20 inline-flex cursor-default rounded-full border-[1px] bg-white pt-1.5 pr-3 pb-1.5 pl-3;
}

.applicable-meta {
Expand All @@ -22,11 +22,9 @@
}

.applicable-separator {
@apply bg-grey-20 mx-2 self-stretch;
mix-blend-mode: multiply;
width: 1px;
height: 100%;
background-color: var(--color-grey-20);
margin-left: calc(var(--spacing) * 2);
margin-right: calc(var(--spacing) * 2);
}
}

Expand Down
10 changes: 3 additions & 7 deletions src/Elastic.Documentation.Site/Assets/markdown/dropdown.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,17 +38,13 @@
}

.applies-dropdown {
@apply flex cursor-pointer items-center gap-1 p-2 px-4 font-normal;
@apply flex cursor-pointer items-center gap-1 p-2 px-2 font-normal;
.applicable-info {
@apply cursor-pointer border-none bg-transparent p-0;
&:not(:last-child):after {
@apply text-sm;
content: ',';
}
@apply cursor-pointer;
}
.applicable-name,
.applicable-meta {
@apply text-sm;
@apply text-xs;
}
}
}
Expand Down
6 changes: 3 additions & 3 deletions src/Elastic.Markdown/Myst/Components/ApplicableToViewModel.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,16 +64,16 @@ public IEnumerable<ApplicabilityItem> GetApplicabilityItems()
{
var items = new List<ApplicabilityItem>();

if (AppliesTo.Stack is not null)
items.AddRange(ProcessSingleCollection(AppliesTo.Stack, ApplicabilityMappings.Stack));

if (AppliesTo.Serverless is not null)
{
items.AddRange(AppliesTo.Serverless.AllProjects is not null
? ProcessSingleCollection(AppliesTo.Serverless.AllProjects, ApplicabilityMappings.Serverless)
: ProcessMappedCollections(AppliesTo.Serverless, ServerlessMappings));
}

if (AppliesTo.Stack is not null)
items.AddRange(ProcessSingleCollection(AppliesTo.Stack, ApplicabilityMappings.Stack));

if (AppliesTo.Deployment is not null)
items.AddRange(ProcessMappedCollections(AppliesTo.Deployment, DeploymentMappings));

Expand Down
30 changes: 15 additions & 15 deletions tests/authoring/Applicability/ApplicableToComponent.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -554,15 +554,6 @@ apm_agent_java: beta 9.1.0
let ``renders complex mixed scenario`` () =
markdown |> convertsToHtml """
<p class="applies applies-block">
<span class="applicable-info" data-tippy-content="We plan to add this functionality in a future Elastic&nbsp;Stack update. Subject to change.

If this functionality is unavailable or behaves differently when deployed on ECH, ECE, ECK, or a self-managed installation, it will be indicated on the page.">
<span class="applicable-name">Stack</span>
<span class="applicable-separator"></span>
<span class="applicable-meta applicable-meta-ga">
Planned
</span>
</span>
<span class="applicable-info" data-tippy-content="We plan to add this functionality in a future Serverless&nbsp;Elasticsearch projects update. Subject to change.

Beta features are subject to change. The design and code is less mature than official GA features and is being provided as-is with no warranties. Beta features are not subject to the support SLA of official GA features.">
Expand All @@ -581,6 +572,15 @@ This functionality may be changed or removed in a future release. Elastic will w
Planned
</span>
</span>
<span class="applicable-info" data-tippy-content="We plan to add this functionality in a future Elastic&nbsp;Stack update. Subject to change.

If this functionality is unavailable or behaves differently when deployed on ECH, ECE, ECK, or a self-managed installation, it will be indicated on the page.">
<span class="applicable-name">Stack</span>
<span class="applicable-separator"></span>
<span class="applicable-meta applicable-meta-ga">
Planned
</span>
</span>
<span class="applicable-info" data-tippy-content="We plan to add this functionality in a future Elastic&nbsp;Cloud&nbsp;on&nbsp;Kubernetes update. Subject to change.

Beta features are subject to change. The design and code is less mature than official GA features and is being provided as-is with no warranties. Beta features are not subject to the support SLA of official GA features.">
Expand Down Expand Up @@ -723,17 +723,17 @@ product: ga 9.0.0
let ``renders missing VersioningSystemId coverage`` () =
markdown |> convertsToHtml """
<p class="applies applies-block">
<span class="applicable-info" data-tippy-content="We plan to add this functionality in a future Elastic&nbsp;Stack update. Subject to change.

If this functionality is unavailable or behaves differently when deployed on ECH, ECE, ECK, or a self-managed installation, it will be indicated on the page.">
<span class="applicable-name">Stack</span>
<span class="applicable-info" data-tippy-content="We plan to add this functionality in a future Elastic&nbsp;Cloud&nbsp;Serverless update. Subject to change.">
<span class="applicable-name">Serverless</span>
<span class="applicable-separator"></span>
<span class="applicable-meta applicable-meta-ga">
Planned
</span>
</span>
<span class="applicable-info" data-tippy-content="We plan to add this functionality in a future Elastic&nbsp;Cloud&nbsp;Serverless update. Subject to change.">
<span class="applicable-name">Serverless</span>
<span class="applicable-info" data-tippy-content="We plan to add this functionality in a future Elastic&nbsp;Stack update. Subject to change.

If this functionality is unavailable or behaves differently when deployed on ECH, ECE, ECK, or a self-managed installation, it will be indicated on the page.">
<span class="applicable-name">Stack</span>
<span class="applicable-separator"></span>
<span class="applicable-meta applicable-meta-ga">
Planned
Expand Down
Loading