Skip to content

Revert applies_to in directives design for recognition value #1977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 1, 2025
Merged

Revert applies_to in directives design for recognition value #1977

merged 3 commits into from
Oct 1, 2025

Conversation

reakaleek
Copy link
Member

@reakaleek reakaleek commented Oct 1, 2025 •
edited
Loading

Closes #1976

Changes

  • Make applies_to in directives more recognizeable by reverting to the original design.
  • Render Serverless before Stack in applies_to

Screenshots

image image

@reakaleek reakaleek requested a review from a team as a code owner October 1, 2025 10:58
@reakaleek reakaleek requested a review from Mpdreamz October 1, 2025 10:58
@reakaleek reakaleek added the fix label Oct 1, 2025
@reakaleek reakaleek self-assigned this Oct 1, 2025
florent-leborgne
florent-leborgne approved these changes Oct 1, 2025
View reviewed changes
Copy link
Contributor

@florent-leborgne florent-leborgne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@reakaleek reakaleek mentioned this pull request Oct 1, 2025
Closed
3 tasks
Mpdreamz
Mpdreamz approved these changes Oct 1, 2025
View reviewed changes
Copy link
Member

@Mpdreamz Mpdreamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@reakaleek reakaleek merged commit 4bb59ab into main Oct 1, 2025
28 of 29 checks passed
@reakaleek reakaleek deleted the feature/applies-to-in-directives-design branch October 1, 2025 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mpdreamz Mpdreamz Mpdreamz approved these changes

@florent-leborgne florent-leborgne florent-leborgne approved these changes

Assignees

@reakaleek reakaleek

Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Applies-switch tab title rendering issue with multiple keys
3 participants
@reakaleek @Mpdreamz @florent-leborgne