Skip to content

Conversation

theletterf
Copy link
Contributor

Fixes #1919 by raising the size of dropdown titles to the size we use for H4 headings.

+CC @karenzone

@theletterf theletterf requested a review from a team as a code owner October 8, 2025 10:20
@theletterf theletterf requested a review from Mpdreamz October 8, 2025 10:20
@theletterf theletterf self-assigned this Oct 8, 2025
@reakaleek
Copy link
Member

This looks a bit too big to me.. but I guess that's just my subjective opinion.

@theletterf
Copy link
Contributor Author

I think an H4 size might make sense considering that we often show these inside H3 (steps) or H2s, instead of fully fledged sections.

@Mpdreamz
Copy link
Member

Mpdreamz commented Oct 8, 2025

I too think its too big but -lg -base differ too little making -xl the only other option.

Does our text-lg need to be bigger but smaller then -xl and use that?

@theletterf
Copy link
Contributor Author

We're using text-lg here:

  1. src/Elastic.Documentation.Site/Layout/_Header.cshtml:25 - On the logo/home link in the header
  2. src/Elastic.Documentation.Site/Layout/_SecondaryNav.cshtml:14 - On the "Docs" link in the secondary navigation

Would it be safe to make it larger for those contexts?

@reakaleek
Copy link
Member

reakaleek commented Oct 8, 2025

I forgot to add text-lg in #2011

I will add it to this PR.

// edit

4ad6abb

@theletterf theletterf merged commit 79ece48 into main Oct 9, 2025
22 checks passed
@theletterf theletterf deleted the css-dropdown-text branch October 9, 2025 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Style: Known issue heading is smaller than body
3 participants