Skip to content

Conversation

cotti
Copy link
Contributor

@cotti cotti commented Mar 14, 2025

On situations where we receive a prebuilt resource path string, an OS check is performed beforehand.

* On situations where we receive a prebuilt resource path string, an OS check is performed beforehand.
@cotti cotti requested a review from a team as a code owner March 14, 2025 00:50
@cotti cotti added the fix label Mar 14, 2025
@cotti cotti linked an issue Mar 14, 2025 that may be closed by this pull request
3 tasks
@cotti cotti self-assigned this Mar 14, 2025
Copy link
Member

@Mpdreamz Mpdreamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small nitpick!

{
var generator = holder.Generator;

if (Environment.OSVersion.Platform == PlatformID.Win32NT)
Copy link
Member

@Mpdreamz Mpdreamz Mar 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (Environment.OSVersion.Platform == PlatformID.Win32NT)
if (RuntimeInformation.IsOSPlatform(OSPlatform.Windows))

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@cotti cotti requested a review from Mpdreamz March 14, 2025 11:58
Copy link
Member

@Mpdreamz Mpdreamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Get it in :D

@cotti cotti merged commit cc708f4 into main Mar 14, 2025
8 checks passed
@cotti cotti deleted the fix/cross-platform-path-resolution branch March 14, 2025 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix docs-builder on Windows
2 participants