-
Notifications
You must be signed in to change notification settings - Fork 156
Reorganize solutions/observability/apm/*
files by owner
#3062
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@colleenmcginnis Lots of work here — thank you! I think this should improve our CODEOWNERS auto-assignments. If redirects hold, I'm fine with going forward with this change and would follow-up with URL updates in the rest of the EDOT reference documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for admin
! 🦘
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes sense to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whitespace deletion looks good to me
Closes #1449
Reorganize
solutions/observability/apm/*
files to make it easier to assign codeowners to specific topics:solutions/observability/apm/apm-agents/*
solutions/observability/apm/apm-server/*
solutions/observability/apm/opentelemetry/*
solutions/observability/apm/ingest/*
(miscellaneous APM pages that don't fit into the categories above, but should be owned by the ingest docs team)solutions/observability/apm/
(these should be about the Applications UI)@theletterf @mdbirnstiehl this is not urgent, but I'd like your take on this approach before I take this out of draft and open it up for review by other teams.