-
Notifications
You must be signed in to change notification settings - Fork 156
dns cache settings page moved to ES configuration section #3142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should move the content to Elasticsearch reference docs, same as GC logging settings?
I think the settings should be duplicated to the JVM setting reference to keep both sets of content complete.
the only reason i'd put it only in the reference is if the relative importance of setting it is reduced
deploy-manage/deploy/self-managed/important-settings-configuration.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Moving
DNS cache settings
content fromimportant system configuration
toImportant settings configuration
section.The important system configuration section is intended for OS settings that need to be configured before installing Elasticsearch, and the DNS cache settings page is a post-installation config item and not even an OS setting.
The content was originally an indivitual page and we are integrating the content into the "important settings configuration" section.
In a separate PR we should also place the content into Elasticsearch reference docs, same as the rest of that page.
Related issue: #3007