-
Notifications
You must be signed in to change notification settings - Fork 156
(Bug) Modify Index Template to LogsDB #962
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 howdy, team! The existing doc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm totally ok with the change, but I've shared a message to propose a slightly bigger change.
We could do that in another PR though.
cc: @marciw , @mdbirnstiehl , feel free to share your thoughts here :)
Thanks @eedugon ! Agreed. Foremost care to stop gap that users using Fleet need to stop running this code and breaking their whole ingest. I like your call out that we can modify the I would normally think this ballpark should go back to Elasticsearch+Fleet+Solutions Dev/Product for those teams to align/confirm how this should be setup+worded. In particular, this example reads to me like it was written to work for Elasticsearch but did not consider Fleet caveats. So does it+we also not know any other Fleet restrictions and/or break anything further down the pipeline for the Solutions (e.g. farther down the page if Elasticsearch Dev's That's my opinion which brings me to my uncertainty: that discussion is for like 3 Dev teams but the PR now comes to |
Merged |
Thanks @stefnestor ! Yes that example at https://www.elastic.co/guide/en/elasticsearch/reference/current/logs-data-stream.html#how-to-use-logsds is very nasty. I think this should be overlooked by the PM of Fleet + PMs of Integrations (and possibly the whole solution teams) and associated leads. So @nimarezainia , @jamiehynds, @daniela-elastic to begin with (for the integrations of o11y & security). I've opened this elastic/integrations#12298 some time ago to have an official "guideline" to enable LogsDB on specific data streams. |
Confirmed high-level discussion will continue in elastic/integrations#12298 . |
👋 howdy, team! ( cc: @asmith-elastic @anniegale9538 for Sev1 01849100 )
The existing docs for Creating LogsDB (v8, v9; believed ported via elastic/elasticsearch#118303) has users create an index template overriding previous which negates all Fleet-managed Integration index pipelines which breaks ingestion patterns across all
logs-*
👻.This adds in a warning header that for Fleet-managed integrations (which AFAIK is the only major exception) users should instead be adding the recommended setting into the component template per existing doc. TIA!