Skip to content

Conversation

marciw
Copy link
Contributor

@marciw marciw commented Dec 9, 2024

This update focuses on licensing and core functionality for the GA release. All suggestions welcome; some will be moved to new issues (coming soon) for fast-follow or 9.0 improvements.

Updated previews

Includes a general editing pass on changes made in #115205 (which didn't get a docs team review) 😿

Closes https://github.com/elastic/search-docs-team/issues/193

Note: I compared the docs to the in-progress blog post and didn't see any gaps, but I'll keep checking the blog post and will link to it from the docs when it's ready.

@marciw marciw added >docs General docs changes Team:Docs Meta label for docs team v9.0.0 v8.17.0 v8.17.1 labels Dec 9, 2024
Copy link
Contributor

github-actions bot commented Dec 9, 2024

Documentation preview:

@marciw marciw marked this pull request as ready for review December 10, 2024 00:19
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

Copy link
Contributor

@leemthompo leemthompo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me. How we call out subscription requirements is the biggest factual question for me.

Otherwise, my main qualm with this page is the structure/headings. Here's a potential heading structure that tries to regroup info, and might make the page easier to scan in the TOC:

Overview

Basic setup

Storage optimization
- Synthetic source
  - Fields without doc values
- Specialized codecs 

Sort settings
- Index sort defaults
- Sort orders and modes

Data validation defaults
- ignore_malformed  
- ignore_above
- ignore_dynamic_beyond_limit

Full settings reference

marciw and others added 2 commits December 10, 2024 10:29
Co-authored-by: Liam Thompson <32779855+leemthompo@users.noreply.github.com>
Co-authored-by: Liam Thompson <32779855+leemthompo@users.noreply.github.com>
@marciw
Copy link
Contributor Author

marciw commented Dec 10, 2024

Changes look good to me. How we call out subscription requirements is the biggest factual question for me.

Otherwise, my main qualm with this page is the structure/headings. Here's a potential heading structure that tries to regroup info, and might make the page easier to scan in the TOC:

Thanks, agreed. Not sure I can tackle this now but will make it a "fast-follow" if not

Copy link
Contributor

@shainaraskas shainaraskas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some nits and questions for you! love the edits - it reads much clearer now

marciw and others added 3 commits December 10, 2024 10:53
Co-authored-by: shainaraskas <58563081+shainaraskas@users.noreply.github.com>
Co-authored-by: shainaraskas <58563081+shainaraskas@users.noreply.github.com>
marciw and others added 4 commits December 10, 2024 17:55
Co-authored-by: Oleksandr Kolomiiets <olkolomiiets@gmail.com>
Co-authored-by: Oleksandr Kolomiiets <olkolomiiets@gmail.com>
Copy link
Contributor

@shainaraskas shainaraskas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logsdb changes lgtm!

are the tsdb "grandfathered" nuances covered anywhere? wondering how people who have old tsdb data streams should expect new ones to behave, or should account for differences between elasticsearch instances.

@marciw marciw removed the v9.0.0 label Dec 11, 2024
@marciw marciw merged commit ae9bb90 into elastic:main Dec 11, 2024
5 checks passed
@marciw marciw added the auto-backport Automatically create backport pull requests when merged label Dec 11, 2024
shainaraskas added a commit to shainaraskas/elasticsearch that referenced this pull request Dec 11, 2024
…#118303)

* Update licensing; fix screenshots; edit generally

* Small edit for clarity and style

* Update docs/reference/index-modules.asciidoc

Co-authored-by: Liam Thompson <32779855+leemthompo@users.noreply.github.com>

* Apply changes from review

Co-authored-by: Liam Thompson <32779855+leemthompo@users.noreply.github.com>

* Address review comments

* Match similar change from review

* More changes from review

* Apply suggestions from review

Co-authored-by: shainaraskas <58563081+shainaraskas@users.noreply.github.com>

* Apply suggestions from review

Co-authored-by: shainaraskas <58563081+shainaraskas@users.noreply.github.com>

* Update docs/reference/data-streams/logs.asciidoc

Co-authored-by: shainaraskas <58563081+shainaraskas@users.noreply.github.com>

* Apply suggestions from review

Co-authored-by: shainaraskas <58563081+shainaraskas@users.noreply.github.com>

* Apply suggestions from review

* Change to general subscription note

* Apply suggestions from review

Co-authored-by: Oleksandr Kolomiiets <olkolomiiets@gmail.com>

* Apply suggestions from review

Co-authored-by: Oleksandr Kolomiiets <olkolomiiets@gmail.com>

* Apply suggestions from review; additional edits

* Apply suggestions from review; clarity tweaks

* Restore previous paragraph structure and context

---------

Co-authored-by: Liam Thompson <32779855+leemthompo@users.noreply.github.com>
Co-authored-by: shainaraskas <58563081+shainaraskas@users.noreply.github.com>
Co-authored-by: Oleksandr Kolomiiets <olkolomiiets@gmail.com>
(cherry picked from commit ae9bb90)
@shainaraskas
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.17

Questions ?

Please refer to the Backport tool documentation

@shainaraskas
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.x

Questions ?

Please refer to the Backport tool documentation

shainaraskas added a commit to shainaraskas/elasticsearch that referenced this pull request Dec 11, 2024
…#118303)

* Update licensing; fix screenshots; edit generally

* Small edit for clarity and style

* Update docs/reference/index-modules.asciidoc

Co-authored-by: Liam Thompson <32779855+leemthompo@users.noreply.github.com>

* Apply changes from review

Co-authored-by: Liam Thompson <32779855+leemthompo@users.noreply.github.com>

* Address review comments

* Match similar change from review

* More changes from review

* Apply suggestions from review

Co-authored-by: shainaraskas <58563081+shainaraskas@users.noreply.github.com>

* Apply suggestions from review

Co-authored-by: shainaraskas <58563081+shainaraskas@users.noreply.github.com>

* Update docs/reference/data-streams/logs.asciidoc

Co-authored-by: shainaraskas <58563081+shainaraskas@users.noreply.github.com>

* Apply suggestions from review

Co-authored-by: shainaraskas <58563081+shainaraskas@users.noreply.github.com>

* Apply suggestions from review

* Change to general subscription note

* Apply suggestions from review

Co-authored-by: Oleksandr Kolomiiets <olkolomiiets@gmail.com>

* Apply suggestions from review

Co-authored-by: Oleksandr Kolomiiets <olkolomiiets@gmail.com>

* Apply suggestions from review; additional edits

* Apply suggestions from review; clarity tweaks

* Restore previous paragraph structure and context

---------

Co-authored-by: Liam Thompson <32779855+leemthompo@users.noreply.github.com>
Co-authored-by: shainaraskas <58563081+shainaraskas@users.noreply.github.com>
Co-authored-by: Oleksandr Kolomiiets <olkolomiiets@gmail.com>
(cherry picked from commit ae9bb90)
shainaraskas added a commit that referenced this pull request Dec 11, 2024
#118504)

* Update licensing; fix screenshots; edit generally

* Small edit for clarity and style

* Update docs/reference/index-modules.asciidoc

Co-authored-by: Liam Thompson <32779855+leemthompo@users.noreply.github.com>

* Apply changes from review

Co-authored-by: Liam Thompson <32779855+leemthompo@users.noreply.github.com>

* Address review comments

* Match similar change from review

* More changes from review

* Apply suggestions from review

Co-authored-by: shainaraskas <58563081+shainaraskas@users.noreply.github.com>

* Apply suggestions from review

Co-authored-by: shainaraskas <58563081+shainaraskas@users.noreply.github.com>

* Update docs/reference/data-streams/logs.asciidoc

Co-authored-by: shainaraskas <58563081+shainaraskas@users.noreply.github.com>

* Apply suggestions from review

Co-authored-by: shainaraskas <58563081+shainaraskas@users.noreply.github.com>

* Apply suggestions from review

* Change to general subscription note

* Apply suggestions from review

Co-authored-by: Oleksandr Kolomiiets <olkolomiiets@gmail.com>

* Apply suggestions from review

Co-authored-by: Oleksandr Kolomiiets <olkolomiiets@gmail.com>

* Apply suggestions from review; additional edits

* Apply suggestions from review; clarity tweaks

* Restore previous paragraph structure and context

---------

Co-authored-by: Liam Thompson <32779855+leemthompo@users.noreply.github.com>
Co-authored-by: shainaraskas <58563081+shainaraskas@users.noreply.github.com>
Co-authored-by: Oleksandr Kolomiiets <olkolomiiets@gmail.com>
(cherry picked from commit ae9bb90)

Co-authored-by: Marci W <333176+marciw@users.noreply.github.com>
shainaraskas added a commit that referenced this pull request Dec 11, 2024
#118505)

* Update licensing; fix screenshots; edit generally

* Small edit for clarity and style

* Update docs/reference/index-modules.asciidoc

Co-authored-by: Liam Thompson <32779855+leemthompo@users.noreply.github.com>

* Apply changes from review

Co-authored-by: Liam Thompson <32779855+leemthompo@users.noreply.github.com>

* Address review comments

* Match similar change from review

* More changes from review

* Apply suggestions from review

Co-authored-by: shainaraskas <58563081+shainaraskas@users.noreply.github.com>

* Apply suggestions from review

Co-authored-by: shainaraskas <58563081+shainaraskas@users.noreply.github.com>

* Update docs/reference/data-streams/logs.asciidoc

Co-authored-by: shainaraskas <58563081+shainaraskas@users.noreply.github.com>

* Apply suggestions from review

Co-authored-by: shainaraskas <58563081+shainaraskas@users.noreply.github.com>

* Apply suggestions from review

* Change to general subscription note

* Apply suggestions from review

Co-authored-by: Oleksandr Kolomiiets <olkolomiiets@gmail.com>

* Apply suggestions from review

Co-authored-by: Oleksandr Kolomiiets <olkolomiiets@gmail.com>

* Apply suggestions from review; additional edits

* Apply suggestions from review; clarity tweaks

* Restore previous paragraph structure and context

---------

Co-authored-by: Liam Thompson <32779855+leemthompo@users.noreply.github.com>
Co-authored-by: shainaraskas <58563081+shainaraskas@users.noreply.github.com>
Co-authored-by: Oleksandr Kolomiiets <olkolomiiets@gmail.com>
(cherry picked from commit ae9bb90)

Co-authored-by: Marci W <333176+marciw@users.noreply.github.com>
@tylerperk
Copy link

Hi @marciw thanks for all the changes. I'll try to do a full review very soon. I did already notice one thing: In https://elasticsearch_bk_118303.docs-preview.app.elstc.co/guide/en/elasticsearch/reference/master/index-modules.html#_static_index_settings it lists "tsds" as a valid index mode. AFAIK this is not valid and should be time_series. TSDS is the common abbreviation for that but is not an actual setting value for ES.

@marciw
Copy link
Contributor Author

marciw commented Dec 12, 2024

Hi @marciw thanks for all the changes. I'll try to do a full review very soon. I did already notice one thing: In https://elasticsearch_bk_118303.docs-preview.app.elstc.co/guide/en/elasticsearch/reference/master/index-modules.html#_static_index_settings it lists "tsds" as a valid index mode. AFAIK this is not valid and should be time_series. TSDS is the common abbreviation for that but is not an actual setting value for ES.

oof, I think that's been there for a long time -- good catch. Fixed in #118579

@marciw marciw mentioned this pull request Dec 12, 2024
sarog pushed a commit to portsbuild/elasticsearch that referenced this pull request Jan 22, 2025
…#118303) (elastic#118504)

* Update licensing; fix screenshots; edit generally

* Small edit for clarity and style

* Update docs/reference/index-modules.asciidoc

Co-authored-by: Liam Thompson <32779855+leemthompo@users.noreply.github.com>

* Apply changes from review

Co-authored-by: Liam Thompson <32779855+leemthompo@users.noreply.github.com>

* Address review comments

* Match similar change from review

* More changes from review

* Apply suggestions from review

Co-authored-by: shainaraskas <58563081+shainaraskas@users.noreply.github.com>

* Apply suggestions from review

Co-authored-by: shainaraskas <58563081+shainaraskas@users.noreply.github.com>

* Update docs/reference/data-streams/logs.asciidoc

Co-authored-by: shainaraskas <58563081+shainaraskas@users.noreply.github.com>

* Apply suggestions from review

Co-authored-by: shainaraskas <58563081+shainaraskas@users.noreply.github.com>

* Apply suggestions from review

* Change to general subscription note

* Apply suggestions from review

Co-authored-by: Oleksandr Kolomiiets <olkolomiiets@gmail.com>

* Apply suggestions from review

Co-authored-by: Oleksandr Kolomiiets <olkolomiiets@gmail.com>

* Apply suggestions from review; additional edits

* Apply suggestions from review; clarity tweaks

* Restore previous paragraph structure and context

---------

Co-authored-by: Liam Thompson <32779855+leemthompo@users.noreply.github.com>
Co-authored-by: shainaraskas <58563081+shainaraskas@users.noreply.github.com>
Co-authored-by: Oleksandr Kolomiiets <olkolomiiets@gmail.com>
(cherry picked from commit ae9bb90)

Co-authored-by: Marci W <333176+marciw@users.noreply.github.com>
stefnestor added a commit to elastic/docs-content that referenced this pull request Apr 3, 2025
👋 howdy, team! ( cc: @asmith-elastic @anniegale9538 for Sev1 01849100 )

The existing docs for Creating LogsDB
([v8](https://www.elastic.co/guide/en/elasticsearch/reference/current/logs-data-stream.html#how-to-use-logsds),
[v9](https://docs-v3-preview.elastic.dev/elastic/docs-content/tree/main/manage-data/data-store/data-streams/logs-data-stream);
believed ported via
elastic/elasticsearch#118303) has users create
an index template overriding previous which negates all Fleet-managed
Integration index pipelines which breaks ingestion patterns across all
`logs-*` 👻.

This adds in a warning header that for Fleet-managed integrations (which
AFAIK is the only major exception) users should instead be adding the
recommended setting [into the component template per existing
doc](https://www.elastic.co/guide/en/observability/current/logs-index-template.html#custom-logs-template-edit).
TIA!

---------

Co-authored-by: shainaraskas <58563081+shainaraskas@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Automatically create backport pull requests when merged >docs General docs changes Team:Docs Meta label for docs team v8.17.0 v8.17.1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants