Skip to content

Conversation

Gschiavon
Copy link
Contributor

Fixed wrong reference to maven central

@jbaiera
Copy link
Member

jbaiera commented Jul 18, 2017

This LGTM, but it seems the CLA checker is failing. Have you signed our Contributor License Agreement?

@Gschiavon
Copy link
Contributor Author

Yes I did, but after doing the PR... so I think it need to refresh somehow?
Regards.

@jbaiera
Copy link
Member

jbaiera commented Jul 19, 2017

@Gschiavon Often times the CLA checker will fail if you sign it with an email address that isn't the same as the one on your github account.

@jbaiera jbaiera self-requested a review July 19, 2017 19:48
@Gschiavon
Copy link
Contributor Author

True, Ive signed it with the same email address now :)

@jbaiera
Copy link
Member

jbaiera commented Jul 25, 2017

I'll give the PR a quick chance to update, and if not I'll dig into what's up with the CLA checker.

@jbaiera
Copy link
Member

jbaiera commented Jul 25, 2017

@Gschiavon The issue here is that the author information on your commit does not match your github information, and thus it cannot be validated. I would fix this with a git commit --amend --reset-author and force push it to your branch.

@Gschiavon Gschiavon force-pushed the fix/mvn-reference branch from 968bf50 to bd3c644 Compare July 26, 2017 06:31
@Gschiavon Gschiavon force-pushed the fix/mvn-reference branch from bd3c644 to d8c164d Compare July 26, 2017 06:40
@Gschiavon
Copy link
Contributor Author

Gschiavon commented Jul 26, 2017

Done @jbaiera, I did git commit --amend --author="Author name email@address" then push it to my branch.

Thanks.

@jbaiera jbaiera added the v6.0.0 label Jul 27, 2017
@jbaiera
Copy link
Member

jbaiera commented Jul 27, 2017

@Gschiavon awesome, thanks! And thank you for the contribution!

@jbaiera jbaiera merged commit 5059c28 into elastic:master Jul 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants