-
Notifications
You must be signed in to change notification settings - Fork 997
Remove YARN Integration #1027
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Remove YARN Integration #1027
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Binary file not shown.
Binary file not shown.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dedemorton the es on yarn project had been deprecated and will be removed from the codebase in 6.0. discontinued sounded perfect to me, but thought you might know better. :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@acchen97 TBH, I would expect to see a discussion of this feature's removal in the release notes rather than the main documentation. I say this because content has a tendency to live longer than we expect. If you put in the release notes, you'll know that it goes away after 6.0.
Curious if @debadair has an opinion on this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dedemorton thanks for the input. The rationale behind having it persistent here is the fact that the project has been around for a couple years at this point, so we'd like to keep this discontinuation visible likely through the 6.x releases before removing it completely in 7.0.
Does that sound reasonable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@acchen97 I don't have a strong opinion either way since I don't own this doc. But I think your point could be made for a lot of features that we remove from the docs over time. Docs can get pretty bloated if we keep stuff like this around, and people forget to remove it. If we are good about flagging deprecation early on and reminding users that the feature is going away, statements like this are unnecessary, IMO. While useful to users in the short term, these statements represent obsolete content that we need to maintain over time. IMO, it's better to train users to look in the release notes. I've been a tech writer for 20+ years so I've seen a lot of stuff like this die on the vine over the years. Anyhow, just something to keep in mind for the future.