Update references to internal precommit plugins #1557
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mark-vieira
added a commit
that referenced
this pull request
Nov 24, 2020
|
Backported to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates some references to refactored tasks in build-tools. Ironically, the cause here is that we are undergoing an effort in Elasticsearch to make better separation between "internal" and "external" build logic, specifically to minimize fallout to external users, such as es-hadoop. The root cause PR is elastic/elasticsearch#65102.
@jbaiera essentially the new contract is that if you use stuff in an
internalpackage we make no breaking changes guarantees. The preferred approach here would be to remove to dependencies on anythinginternalin build-tools. In fact, we eventually intend to remove that stuff entirely and simply not include them in the published build-tools jar.