Remove problem dependency #1686
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💚 CLA has been signed |
|
Opened against master in error |
mark-vieira
approved these changes
Jun 10, 2021
| project.repositories.maven { url "https://conjars.org/repo" } | ||
| project.repositories.maven { url "https://clojars.org/repo" } | ||
| project.repositories.maven { url 'https://repo.spring.io/plugins-release' } | ||
| project.repositories.maven { url 'https://repo.spring.io/plugins-release-local' } |
There was a problem hiding this comment.
Why was this required in addition to dropping the dependency?
There was a problem hiding this comment.
I've reverted this. It doesn't seem like we actually make use of this repository at all, especially since as it is it requires authorization to access. I'll put out a follow up to clean it out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Snapshot builds and CI is failing because a dependency cannot be reliably pulled from the repository it is in. The locations it is persisted in are either inaccessible or being sunset, and we luckily do not even use it, so this PR removes it from being considered by the build.