Thread safety

[mjwills]

This is more of a question rather than an issue.

If I instantiate a single ElasticClient and use it from multiple threads (without altering ConnectionSettings), should I expect the object to work correctly?

The methods I call from one thread (the 'writer') are:

public bool IsValid { get; }
public ConnectionStatus Index(IEnumerable objects) where T : class;

And from the other (the 'reader') are:

public bool IsValid { get; }
public QueryResponse Search(string search, string index, string typeName) where T : class;

Looking at the NEST code, I think this is safe. Is this safe, or would I be best to instantiate separate reader and writer clients?

[Mpdreamz]

The ElasticClient holds a single IConnection responsible for doing async and sync http calls.
The IConnection does not reuse httprequests and uses thread local state for data thats being passed around during the stages of the request. It should thus be thread safe.

See: https://github.com/Mpdreamz/NEST/blob/master/src/Nest/Domain/Connection/Connection.cs

If you do run into issues i'd love to hear so, i've used a singlie Elastic Client to paralize index calls without hiccups myself. See also the hacker news demo project.

[mjwills]

Excellent. Ta.

[tugberkugurlu]

couldn't find this info inside the docs. would be nice to have this there.