Unable to get server side mappings due to unexpected boolean type (string)

[niemyjski]

Elastic 7.4.0 and NEST 7.3.0 are failing when I try to get the index mapping:

Elasticsearch.Net.Utf8Json.JsonParsingException: expected:'true | false', actual:'"false"', at offset:77
  at at Elasticsearch.Net.Utf8Json.JsonReader.ReadBoolean()
  at at Elasticsearch.Net.Utf8Json.Formatters.BooleanFormatter.Deserialize(JsonReader& reader, IJsonFormatterResolver formatterResolver)
  at at Nest.UnionFormatter`2.TryRead[T](ArraySegment`1& segment, IJsonFormatterResolver formatterResolver, T& v)

{
  "daily-logevents-v1-2019.10.08" : {
    "mappings" : {
      "dynamic" : "false",
      "properties" : {
        "companyId" : {
          "type" : "keyword"
        },
        "created" : {
          "type" : "alias",
          "path" : "createdUtc"
        },
        "createdUtc" : {
          "type" : "date"
        },
        "id" : {
          "type" : "keyword"
        },
        "message" : {
          "type" : "text",
          "fields" : {
            "keyword" : {
              "type" : "keyword",
              "ignore_above" : 256
            }
          }
        },
        "value" : {
          "type" : "integer"
        }
      }
    }
  }
}

As you can see I defined dynamic through the nest fluent api and this is breaking.

[niemyjski]

Looks like elasticsearch dynamic is treating it as string directly..

[russcam]

This is a consequence of the strictness of the Utf8Json deserializer; a custom formatter needs to be used here to deserialize a boolean string to bool. I'll open a PR for it now

[russcam]

I've opened #4127

[niemyjski]

Thank you!