Do not include .pdb files to nuget package, create separate .symbols.nupkg package instead

[maximpashuk]

Consider to NuGet documentation
http://docs.nuget.org/docs/creating-packages/creating-and-publishing-a-symbol-package

Instead of including .pdb files to .nupkg directly, use -Source nuget option to generate special type of package - .symbols.nupkg package that keep pbd files and sources.
Publish main package to nuget.org and symbols package to symbolsource.org - this canbe arrived by one command.

None of popular nuget packages (newtonsoft.json for example) include pdb files.
NEST nuget package also should not contain pdb files, pdb and sources should be available at symbolsource.org

[Mpdreamz]

Hi @maximpashuk

This is definitely the way to do this however it will be low on my priority list right now.

I accept pull requests for this! ;)

[Mpdreamz]

@maximpashuk if you find some time to help out with this it would be much appreciated. It's very low on my priority list.

[YogirajA]

@maximpashuk @Mpdreamz I can take this if you guys don't mind.

[Mpdreamz]

@YogirajA this is not high on my priority list at all so any work here will be much appreciated:

My personal preference would be to keep redistributing the pdb's and use githublink on them instead of symbolsource servers:

https://github.com/geertvanhorrik/githublink

This makes the whole debug experience much much nicer IMO. Unless there are big objections other then size to do this that I'm not aware of?

[Mpdreamz]

ping @GeertvanHorrik (would love your thoughts on this issue as well)

[GeertvanHorrik]

None of popular nuget packages (newtonsoft.json for example) include pdb files.

That's because they have never heard of GitHubLink (or it wasn't available at that time). Although the size of the nuget packages will increase, using separate packages:

1. Increases the management difficulty
2. Requires enabling and setting up symbol source server for it to work

There are 2 downsides of including PDB files in the main nuget package:

1. Symbols will automatically be loaded (but debugger cannot find source)
2. The size of the package will be bigger (but since all is zipped, it's all relative)

GitHubLink solves the first issue by redirecting the debugger to GitHub source files. My recommendation is to keep including the pdb files and enable GitHubLink. This will allow every developer to step through the source code of elasticsearch if they want to. It also makes pushing packages faster (no more pushing to symbol source) and more robust (my publishing failed numerous times to symbol source).

[Mpdreamz]

Closing this because we now ship with gitlink indexing our source.