Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add String Stats Aggregation #4369

Closed
russcam opened this issue Feb 5, 2020 · 0 comments
Closed

Add String Stats Aggregation #4369

russcam opened this issue Feb 5, 2020 · 0 comments
Assignees
@russcam

Comments

@russcam
Copy link
Contributor

russcam commented Feb 5, 2020

Relates: #4341

Implement stats aggregation for string terms (elastic/elasticsearch#47468)
@russcam russcam self-assigned this Feb 5, 2020
russcam added a commit that referenced this issue Feb 6, 2020
@russcam
Add StringStats aggregation
5c6cc23 
This commit adds support for the string_stats aggregation introduced in
Elasticsearch 7.6.0. It is a metric aggregation but does not implement
IMetricAggregation because the type of Missing field is a string and not a
double value. Missing is implemented as object as the hierarchy of
metric aggregations will be changed as part of #4332, and Missing
will be an object.

The documentation for StringStats indicates that the distribution is returned
in descending probability order, but are modelled as a JSON object. Following
internal discussion, this is modelled as a dictionary on the response as it is
considered this modelling will not diminish functionality.

Closes #4369
@russcam russcam mentioned this issue Feb 6, 2020
Merged
russcam added a commit that referenced this issue Feb 10, 2020
@russcam
Add StringStats aggregation (#4370)
cc45fb1 
This commit adds support for the string_stats aggregation introduced in
Elasticsearch 7.6.0. It is a metric aggregation but does not implement
IMetricAggregation because the type of Missing field is a string and not a
double value. Missing is implemented as object as the hierarchy of
metric aggregations will be changed as part of #4332, and Missing
will be an object.

The documentation for StringStats indicates that the distribution is returned
in descending probability order, but are modelled as a JSON object. Following
internal discussion, this is modelled as a dictionary on the response as it is
considered this modelling will not diminish functionality.

Closes #4369
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@russcam russcam

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@russcam