-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Description
BulkAll has an option to continue after dropped documents:
bool ContinueAfterDroppedDocuments { get; } |
HandleDroppedDocuments takes this setting into account and only throws an exception if we are not continueing after seeing dropped documents
elasticsearch-net/src/Elastic.Clients.Elasticsearch/Helpers/BulkAllObservable.cs
Line 173 in 584edb8
HandleDroppedDocuments(droppedDocuments, response); |
However later after retrying we through if we still hold retryableDocuments. This should also check this configuration setting and treat them as dropped documents:
However later we don't classify retried to completion bulk items as dropped and do not make this check conditional:
elasticsearch-net/src/Elastic.Clients.Elasticsearch/Helpers/BulkAllObservable.cs
Line 178 in 584edb8
if (retryableDocuments.Count > 0) |