Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Please add a property to set expected similarity to KnnQueryDescriptor. #7952

Closed
mikkel-busch opened this issue Sep 28, 2023 · 2 comments · Fixed by #7956
Closed

Please add a property to set expected similarity to KnnQueryDescriptor. #7952

mikkel-busch opened this issue Sep 28, 2023 · 2 comments · Fixed by #7956
Labels
8.x Relates to 8.x client version

Comments

@mikkel-busch
Copy link

Is your feature request related to a problem? Please describe.

The class KnnQueryDescriptor

Does not seem to have a similarity property to set expected similarity.

The documentation states that such a parameter should exist for KNN search.

Describe the solution you'd like
I would like the property to be added.

Describe alternatives you've considered
Currently the filtering can be done client side, but this add some unnecessary overhead.
@flobernd flobernd added the 8.x Relates to 8.x client version label Sep 28, 2023
@flobernd
Copy link
Member

Hi @mikkel-busch!

This is a specification issue which just got fixed: elastic/elasticsearch-specification#2261.

The fix will be included in the next release.

@mikkel-busch
Copy link
Author

Sounds good. Thank you for the fast reply.

@flobernd flobernd mentioned this issue Sep 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
8.x Relates to 8.x client version
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Similarity to KnnQuery elastic/elasticsearch-net
2 participants
@flobernd @mikkel-busch