MapFromAttributes ignores FieldType.Completion

[sven-h]

Hi everyone,

while working with NEST Version 1.0.2, I think I found a small mistake when using AddMapping(m => m.MapFromAttributes()) with an Property of type Completion like

[ElasticProperty(Type = FieldType.Completion)]
public string Autocomplete { get; set; }

There might be missing a case block for "completion" in file src/Nest/Resolvers/Converters/ElasticTypeConverter.cs method GetTypeFromJObject.
My proposal is another catch block

case "completion":
    return serializer.Deserialize(po.CreateReader(), typeof(CompletionMapping)) as CompletionMapping;

but I don't have the full overview of the project, so this is only a guess.

Best regards
Sven

[gmarz]

Hey @sven-h

Attribute based mappings were originally intended for simple/core types, e.g. string, boolean, date, etc. "Quick wins", if you will.

More complex mappings, such as nested, multifield, and completion require specifying options along with them, and thus we prefer you use the Put Mapping request/descriptor instead, or add the mapping at the time you are creating your index. For this reason, we purposely left out the completion type from the attribute based mappings.

This is definitely an area of confusion in NEST, and we've received a few issues/comments regarding attributes. We plan on addressing this soon (v2.0)- and are either going to remove attributes entirely in favor of the above methods (eliminating the confusion), or rethink the entire implementation so that all mapping types are supported (may not be feasible).

Let me know if you need any help getting the above Put Mapping request to work.

[sven-h]

Hey @gmarz

thanks for your anser.
I already changed my code to a Put Mapping. It was only a bit confusing why completion exists as an attribute and is not being translated to the request.
From now on I will use Put Mapping for creating the mapping.

Best regards
Sven